Opened 8 years ago
Closed 8 years ago
#14210 closed defect (fixed)
clean up Matrix_mpolynomial_dense
Reported by: | malb | Owned by: | jason, was |
---|---|---|---|
Priority: | major | Milestone: | sage-5.12 |
Component: | linear algebra | Keywords: | |
Cc: | Bouillaguet, SimonKing | Merged in: | sage-5.12.beta1 |
Authors: | Martin Albrecht, Volker Braun | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Matrix_mpolynomial_dense
while short is a mess. It's docstrings are not doctested due to formatting errors and it used hardcoded calls to libSingular where the more modern libSingular function factory should be used.
Attachments (2)
Change History (9)
Changed 8 years ago by
comment:1 Changed 8 years ago by
- Cc Bouillaguet SimonKing added
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
Looks good. You touch det
but don't fix the following bug:
sage: R.<x,y> = QQ[] sage: m = matrix([[y,y,y,y]] * 4) sage: m.charpoly() x^4 - 4*y*x^3 sage: m.det() --------------------------------------------------------------------------- AttributeError Traceback (most recent call last) <ipython-input-13-398222b460ca> in <module>() ----> 1 m.det() /home/vbraun/opt/sage-5.11.beta3/local/lib/python2.7/site-packages/sage/matrix/matrix2.so in sage.matrix.matrix2.Matrix.det (sage/matrix/matrix2.c:9875)() /home/vbraun/opt/sage-5.11.beta3/local/lib/python2.7/site-packages/sage/matrix/matrix_mpolynomial_dense.so in sage.matrix.matrix_mpolynomial_dense.Matrix_mpolynomial_dense.determinant (sage/matrix/matrix_mpolynomial_dense.cpp:5736)() /home/vbraun/opt/sage-5.11.beta3/local/lib/python2.7/site-packages/sage/structure/element.so in sage.structure.element.Element.__getattr__ (sage/structure/element.c:3871)() /home/vbraun/opt/sage-5.11.beta3/local/lib/python2.7/site-packages/sage/structure/misc.so in sage.structure.misc.getattr_from_other_class (sage/structure/misc.c:1696)() AttributeError: 'sage.rings.polynomial.polynomial_element.Polynomial_generic_dense' object has no attribute 'keys'
comment:3 Changed 8 years ago by
- Reviewers set to Volker Braun
I've added a reviewer patch that cleans up the docstrings some more, achieves 100% coverage, and actually adds it to the reference manual. And fixes the det() bug.
Positive review to the original patch...
comment:4 Changed 8 years ago by
- Type changed from PLEASE CHANGE to defect
comment:5 Changed 8 years ago by
- Status changed from needs_review to positive_review
Reviewer patch looks okay to me.
comment:6 Changed 8 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:7 Changed 8 years ago by
- Merged in set to sage-5.12.beta1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
The attached patch
matrix_mpolynomial_dense.pyx
and replaces them by calls through the libSingular function interface.matrix_mpolynomial_dense.pyx
)