Opened 9 years ago

Last modified 9 years ago

#14188 closed enhancement

IPython 0.13: merge user configuration with Sage configuration — at Version 5

Reported by: jhpalmieri Owned by: jason
Priority: minor Milestone: sage-5.8
Component: misc Keywords: IPython config
Cc: vbraun, jason Merged in:
Authors: John Palmieri, Volker Braun Reviewers: Volker Braun, William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

After #12719, user configuration files (in .sage/ipython-0.12/profile_default/ and .../profile_sage/) seem to be effectively ignored: I think they are read after the Sage terminal app has already been initialized, at which point it is too late.

The attached patch remedies this, reading the configuration from .sage/ipython-0.12/profile_default/ipython_config.py during the initialization. Question: should it read from this directory or from profile_sage?

Apply trac_14188_vb.patch

Change History (6)

comment:1 Changed 9 years ago by vbraun

It should read from /profile_sage/ipython_config.py for sure.

comment:2 Changed 9 years ago by jhpalmieri

  • Status changed from new to needs_review

comment:3 Changed 9 years ago by jhpalmieri

Here's a new version which reads from profile_sage.

Changed 9 years ago by vbraun

Reworked patch

comment:4 Changed 9 years ago by vbraun

I changed your code to override load_config_file() instead of stuffing it in the ctor. Now the configuration is only loaded once, as one can easily check by putting a print statement into ipython_config.py.

Also, after discussion with Jason and William we decided to default to colors in the terminal. For simplicity I just added this into this patch.

comment:5 Changed 9 years ago by vbraun

  • Authors changed from John Palmieri to John Palmieri, Volker Braun
  • Description modified (diff)
  • Reviewers set to Volker Braun, William Stein

And I agree with your changes, of course. Feel free to set it to positive review if you are happy with it.

Note: See TracTickets for help on using tickets.