Opened 7 years ago

Closed 7 years ago

#14183 closed task (fixed)

Unnecessary replication of Code in sage/logic/boolformula.py

Reported by: knsam Owned by: burcin
Priority: major Milestone: sage-5.9
Component: symbolics Keywords: logic
Cc: Merged in: sage-5.9.beta1
Authors: Kannappan Sampath Reviewers: Punarbasu Purkayastha
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The functions convert_cnf is simply the function convert_cnf_table. Although, this has been acknowledged in the docstring, the very implementation seems out of the way. We usually, declare the functions equal instead of having different docstrings and such. So, I have done this in this case with minor tweaks in the documentation.

Attachments (1)

trac_14183_aliasing.patch (4.0 KB) - added by knsam 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by knsam

comment:1 Changed 7 years ago by knsam

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by ppurka

  • Reviewers set to Punarbasu Purkayastha
  • Status changed from needs_review to positive_review

Looks good to me and passes all doctests @patchbot.

comment:3 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.9.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.