Opened 7 years ago

Closed 7 years ago

#14182 closed defect (fixed)

Fix whitespace in coercion_and_categories.rst

Reported by: jdemeyer Owned by: mvngu
Priority: blocker Milestone: sage-5.8
Component: documentation Keywords:
Cc: SimonKing Merged in: sage-5.8.beta2
Authors: Jeroen Demeyer Reviewers: Simon King
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11490 Stopgaps:

Description

devel/sage/doc/en/thematic_tutorials/coercion_and_categories.rst mixes TABs and spaces for indentation, which is very bad style and might also lead to doctesting trouble.

Attachments (1)

14182_whitespace.patch (9.0 KB) - added by jdemeyer 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by SimonKing

How to replace tabs by four blank spaces (in linux or vim)? Perhaps you can answer faster than I can look up in google...

Changed 7 years ago by jdemeyer

comment:2 Changed 7 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:3 Changed 7 years ago by SimonKing

OK, you were faster. I found sed 's/\\t/ /g' oldcode.py >newcode.py in google...

comment:4 Changed 7 years ago by SimonKing

  • Reviewers set to Simon King
  • Status changed from needs_review to positive_review

Good. After applying the patch, I could not find any tab space in the code. Since the patch does not change the actual text, since the documentation built w/o trouble, and since the result looks fine in the browser, I give it a positive review.

Last edited 7 years ago by SimonKing (previous) (diff)

comment:5 Changed 7 years ago by roed

  • Dependencies set to #11490

comment:6 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.8.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.