Opened 12 years ago

Closed 12 years ago

#1418 closed enhancement (fixed)

[with patch, with positive review] magma element __floordiv__

Reported by: jbmohler Owned by: was
Priority: minor Milestone: sage-2.10.1
Component: interfaces Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

I added a __floordiv__ to the magma element for the 'div' operator.

Attachments (1)

magma_floordiv.patch (1.1 KB) - added by jbmohler 12 years ago.
a fixed patch which should work

Download all attachments as: .zip

Change History (9)

comment:1 Changed 12 years ago by jbmohler

  • Milestone changed from sage-2.9 to sage-2.10

Oops, this should go on hold. I screwed it up in various ways with the doc-tests.

comment:2 Changed 12 years ago by mhansen

  • Milestone changed from sage-2.10 to sage-2.9
  • Summary changed from magma element __floordiv__ to [with patch] magma element __floordiv__

comment:3 Changed 12 years ago by mabshoff

  • Summary changed from [with patch] magma element __floordiv__ to [with borken patch] magma element __floordiv__

comment:4 Changed 12 years ago by mabshoff

  • Summary changed from [with borken patch] magma element __floordiv__ to [with broken patch] magma element __floordiv__

Changed 12 years ago by jbmohler

a fixed patch which should work

comment:5 Changed 12 years ago by jbmohler

  • Summary changed from [with broken patch] magma element __floordiv__ to [with patch] magma element __floordiv__

I just added a patch which adds "# optional" at the right points.

comment:6 Changed 12 years ago by rlm

  • Summary changed from [with patch] magma element __floordiv__ to [with patch, needs review] magma element __floordiv__

comment:7 Changed 12 years ago by ncalexan

  • Summary changed from [with patch, needs review] magma element __floordiv__ to [with patch, with positive review] magma element __floordiv__

Looks fine, apply.

comment:8 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 2.10.1.alpha1

Note: See TracTickets for help on using tickets.