Opened 8 years ago

Closed 8 years ago

#14174 closed enhancement (fixed)

Remove coxeter matrix implementation for type H (the generic implementation is just as good)

Reported by: nthiery Owned by: sage-combinat
Priority: major Milestone: sage-5.8
Component: combinatorics Keywords: coxeter3
Cc: Merged in: sage-5.8.beta2
Authors: Nicolas M. Thiéry Reviewers: Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12912 Stopgaps:

Description (last modified by nthiery)

This is a followup to #12912 where this method was inadvertently not removed.

Attachments (1)

trac_14174-coxeter_matrix-type_H.patch​ (1.1 KB) - added by nthiery 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by nthiery

comment:1 Changed 8 years ago by nthiery

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 follow-up: Changed 8 years ago by aschilling

  • Dependencies set to #12912
  • Keywords coxeter3 added

comment:3 in reply to: ↑ 2 Changed 8 years ago by aschilling

If the patchbot turns green, I am happy with this!

Anne

comment:4 Changed 8 years ago by aschilling

  • Status changed from needs_review to positive_review

comment:5 Changed 8 years ago by nthiery

For the record: the patchbot failure comes from it complaining about not knowing how to handle the spkg for #12912

comment:6 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.8.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.