Opened 6 years ago
Closed 6 years ago
#14173 closed defect (fixed)
Stopgap warning in Graph.modular_decomposition
Reported by: | ncohen | Owned by: | jason, ncohen, rlm |
---|---|---|---|
Priority: | blocker | Milestone: | sage-5.8 |
Component: | graph theory | Keywords: | |
Cc: | dcoudert, hivert, nthiery | Merged in: | sage-5.8.beta2 |
Authors: | Nathann Cohen | Reviewers: | Luis Felipe Tabera Alonso |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
As the title says ! And because I just learned about it :-)
https://groups.google.com/d/topic/sage-devel/lc2Nf75kjsY/discussion
This patch adds a warning meant to everybody who uses modular_decomposition, for as long as #13744 is not fixed.
Nathann
Attachments (1)
Change History (10)
comment:1 Changed 6 years ago by
- Cc hivert nthiery added
- Description modified (diff)
- Status changed from new to needs_review
- Stopgaps set to #13744, #14019
- Summary changed from Warning in modular_decomposition which is known to return wrong results to Stopgap warning in Graph.modular_decomposition and Poset.relabel
comment:2 Changed 6 years ago by
- Priority changed from major to blocker
comment:3 follow-up: ↓ 6 Changed 6 years ago by
Nathan, I think that if both issues are unrelated it would be better if you open two different stopgap tickets, once per issue.
comment:4 Changed 6 years ago by
Two one-line ticket ?....
Nathann
comment:5 Changed 6 years ago by
- Description modified (diff)
- Stopgaps changed from #13744, #14019 to #13744
- Summary changed from Stopgap warning in Graph.modular_decomposition and Poset.relabel to Stopgap warning in Graph.modular_decomposition
Changed 6 years ago by
comment:6 in reply to: ↑ 3 Changed 6 years ago by
Nathan, I think that if both issues are unrelated it would be better if you open two different stopgap tickets, once per issue.
Done ... #14185 is now in charge of Poset.relabel.
Nathann
comment:7 Changed 6 years ago by
- Reviewers set to Luis Felipe Tabera Alonso
- Status changed from needs_review to positive_review
- Stopgaps #13744 deleted
comment:8 Changed 6 years ago by
THaaaaaaaaaaaaanks !! :-)
Nathann
comment:9 Changed 6 years ago by
- Merged in set to sage-5.8.beta2
- Resolution set to fixed
- Status changed from positive_review to closed
(because that's what is written in the developper's manual. And because it makes sense, too !)