Opened 8 years ago

Closed 7 years ago

#14165 closed enhancement (wontfix)

Computing number fields as subfields of algebraic field.

Reported by: mmarco Owned by: mmarco
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: number fields Keywords:
Cc: cwitty Merged in:
Authors: Reviewers: Miguel Marco
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Adds a method to algebraic field for computing the subfield spanned by some elements.

It may be useful, for example, to transform polynomials over QQbar, or over AA, into polynomials over a number field (which can be then treated by singular).

Attachments (1)

14165_add_subfield.patch (2.5 KB) - added by mmarco 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by mmarco

comment:1 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:2 Changed 7 years ago by mmezzarobba

Wouldn't the new method be redundant with number_field_elements_from_algebraics?

comment:3 Changed 7 years ago by mmarco

Yes, you are right.

comment:4 Changed 7 years ago by mmezzarobba

  • Milestone changed from sage-6.1 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

WONTFIX then? Or should we add a wrapper of the existing function with the user interface that you suggested?

comment:5 Changed 7 years ago by mmarco

The only thing that my patch adds to the existing function is the possibility to choose the name of the generator. As far as i am concerned, it would be ok to close this ticket as wontfix, and, if somebody considers that the name of the generator is important, open a ticket to add that option to the existing function.

Anyways, i would like to run some tests to compare my code with the existing one. Most likely my code will be worse, but it would be worth to check it, just in case.

comment:6 Changed 7 years ago by mmarco

  • Owner changed from davidloeffler to mmarco

Ok, my code is definitely worse.

comment:7 Changed 7 years ago by jdemeyer

  • Reviewers set to Miguel Marco
  • Status changed from needs_review to positive_review

comment:8 Changed 7 years ago by vbraun

  • Branch set to u/vbraun/number_subfields

comment:9 Changed 7 years ago by vbraun

  • Branch u/vbraun/number_subfields deleted
  • Resolution set to wontfix
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.