Opened 7 years ago

Closed 7 years ago

#14160 closed defect (fixed)

Fix bug with the antipode in NonCommutativeSymmetricFunctions

Reported by: zabrocki Owned by: sage-combinat
Priority: major Milestone: sage-5.8
Component: combinatorics Keywords:
Cc: chrisjamesberg, saliola Merged in: sage-5.8.beta1
Authors: Mike Zabrocki Reviewers: Franco Saliola
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Fixes a bug in the antipode for non-commutative symmetric functions and adds a few doc-tests to check that it is correct

Attachments (1)

trac_14160_fix_ncsf_antipode-mz.patch (2.0 KB) - added by zabrocki 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by zabrocki

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by saliola

  • Authors changed from zabrocki to Mike Zabrocki
  • Reviewers set to Franco Saliola
  • Status changed from needs_review to positive_review

Looks good to me.

Ticket #14161 requests that a _test_antipode method be implemented (which would have caught this bug!)

comment:3 Changed 7 years ago by saliola

  • Status changed from positive_review to needs_work

Mike, one more thing : you need to add the ticket number to the patch description.

Changed 7 years ago by zabrocki

comment:4 Changed 7 years ago by zabrocki

  • Status changed from needs_work to needs_review

comment:5 Changed 7 years ago by saliola

  • Status changed from needs_review to positive_review

comment:6 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.8.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.