Opened 7 years ago

Closed 7 years ago

#14158 closed defect (fixed)

_is_Field() ignores exceptions

Reported by: jdemeyer Owned by: robertwb
Priority: blocker Milestone: sage-5.8
Component: coercion Keywords:
Cc: Merged in: sage-5.8.beta2
Authors: Jeroen Demeyer Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

#13370 changed

def bint _is_Field(x)

to

cpdef bint _is_Field(x)

without an except declaration.

For example, I have seen in between doctests:

sage -t  --long -force_lib devel/sage/sage/graphs/generic_graph.py
Exception RuntimeError: RuntimeError("Gap produced error output\nError, Variable: 'is_field' must have a value\n\n   executing is_field();",) in 'sage.rings.ring._is_Field' ignored

Attachments (1)

14158_is_field_except.patch (836 bytes) - added by jdemeyer 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by jdemeyer

comment:1 Changed 7 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:2 Changed 7 years ago by roed

  • Status changed from needs_review to positive_review

Looks good to me.

comment:3 Changed 7 years ago by roed

  • Reviewers set to David Roe

comment:4 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.8.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.