Opened 10 years ago
Closed 10 years ago
#14158 closed defect (fixed)
_is_Field() ignores exceptions
Reported by: | Jeroen Demeyer | Owned by: | Robert Bradshaw |
---|---|---|---|
Priority: | blocker | Milestone: | sage-5.8 |
Component: | coercion | Keywords: | |
Cc: | Merged in: | sage-5.8.beta2 | |
Authors: | Jeroen Demeyer | Reviewers: | David Roe |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
#13370 changed
def bint _is_Field(x)
to
cpdef bint _is_Field(x)
without an except
declaration.
For example, I have seen in between doctests:
sage -t --long -force_lib devel/sage/sage/graphs/generic_graph.py Exception RuntimeError: RuntimeError("Gap produced error output\nError, Variable: 'is_field' must have a value\n\n executing is_field();",) in 'sage.rings.ring._is_Field' ignored
Attachments (1)
Change History (5)
Changed 10 years ago by
Attachment: | 14158_is_field_except.patch added |
---|
comment:1 Changed 10 years ago by
Authors: | → Jeroen Demeyer |
---|---|
Status: | new → needs_review |
comment:2 Changed 10 years ago by
Status: | needs_review → positive_review |
---|
comment:3 Changed 10 years ago by
Reviewers: | → David Roe |
---|
comment:4 Changed 10 years ago by
Merged in: | → sage-5.8.beta2 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Looks good to me.