Opened 7 years ago

Closed 7 years ago

#14152 closed defect (fixed)

Add sig_on_count() check check

Reported by: jdemeyer Owned by: roed
Priority: minor Milestone: sage-5.9
Component: doctest framework Keywords:
Cc: Merged in: sage-5.9.beta4
Authors: Jeroen Demeyer Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #13610 Stopgaps:

Description

We should add a check to check that the doctesting framework correctly checks the value of _signals.sig_on_count. We should also keep it in check by setting it to zero, because a non-zero value is a blank cheque for the doctester to fail every subsequent sig_on_count() check.

Attachments (1)

14152_sig_on_check.patch (3.7 KB) - added by jdemeyer 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by roed

  • Component changed from doctest to doctest framework
  • Owner changed from mvngu to roed

Changed 7 years ago by jdemeyer

comment:2 Changed 7 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:3 Changed 7 years ago by roed

  • Status changed from needs_review to positive_review

Looks good to me.

comment:4 Changed 7 years ago by jdemeyer

  • Reviewers set to David Roe

comment:5 Changed 7 years ago by jdemeyer

  • Dependencies set to #13610

comment:6 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.9.beta4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.