Opened 10 years ago

Closed 10 years ago

#14152 closed defect (fixed)

Add sig_on_count() check check

Reported by: Jeroen Demeyer Owned by: David Roe
Priority: minor Milestone: sage-5.9
Component: doctest framework Keywords:
Cc: Merged in: sage-5.9.beta4
Authors: Jeroen Demeyer Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #13610 Stopgaps:

Status badges

Description

We should add a check to check that the doctesting framework correctly checks the value of _signals.sig_on_count. We should also keep it in check by setting it to zero, because a non-zero value is a blank cheque for the doctester to fail every subsequent sig_on_count() check.

Attachments (1)

14152_sig_on_check.patch​ (3.7 KB) - added by Jeroen Demeyer 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by David Roe

Component: doctest → doctest framework
Owner: changed from Minh Van Nguyen to David Roe

Changed 10 years ago by Jeroen Demeyer

Attachment: 14152_sig_on_check.patch​ added

comment:2 Changed 10 years ago by Jeroen Demeyer

Authors: → Jeroen Demeyer
Status: new → needs_review

comment:3 Changed 10 years ago by David Roe

Status: needs_review → positive_review

Looks good to me.

comment:4 Changed 10 years ago by Jeroen Demeyer

Reviewers: → David Roe

comment:5 Changed 10 years ago by Jeroen Demeyer

Dependencies: → #13610

comment:6 Changed 10 years ago by Jeroen Demeyer

Merged in: → sage-5.9.beta4
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.