Opened 4 years ago

Closed 4 years ago

#14142 closed defect (fixed)

Making mutable copies of simplicial complexes

Reported by: tscrim Owned by: tscrim
Priority: major Milestone: sage-5.8
Component: algebraic topology Keywords: mutable copy simplicial complex
Cc: jhpalmieri Merged in: sage-5.8.beta2
Authors: Travis Scrimshaw Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by tscrim)

After #12587, one could make simplicial complexes immutable in order for them to be hashable. However there was no functionality to make mutable copies.

Attachments (1)

trac_14142-mutable_copy_simplicial-ts.patch (4.7 KB) - added by tscrim 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by tscrim

  • Description modified (diff)

comment:2 Changed 4 years ago by tscrim

  • Status changed from new to needs_review

comment:3 Changed 4 years ago by jhpalmieri

This looks pretty good. I think it should be documented in one more place, maybe in the top-level docstring, in the mutability section, say around line 133.

comment:4 Changed 4 years ago by tscrim

I've added the doctests you requested.

Best,
Travis

comment:5 Changed 4 years ago by jhpalmieri

Great. Change "a mutable copies" (line 135) and I'll give it a positive review.

comment:6 Changed 4 years ago by tscrim

Done. I also changed the hash test to a better formatted test.

Changed 4 years ago by tscrim

comment:7 Changed 4 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

comment:8 Changed 4 years ago by tscrim

Thank you for the review.

comment:9 Changed 4 years ago by jdemeyer

  • Merged in set to sage-5.8.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.