Opened 5 years ago
Closed 5 years ago
#14142 closed defect (fixed)
Making mutable copies of simplicial complexes
Reported by: | tscrim | Owned by: | tscrim |
---|---|---|---|
Priority: | major | Milestone: | sage-5.8 |
Component: | algebraic topology | Keywords: | mutable copy simplicial complex |
Cc: | jhpalmieri | Merged in: | sage-5.8.beta2 |
Authors: | Travis Scrimshaw | Reviewers: | John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
After #12587, one could make simplicial complexes immutable in order for them to be hashable. However there was no functionality to make mutable copies.
Attachments (1)
Change History (10)
comment:1 Changed 5 years ago by
- Description modified (diff)
comment:2 Changed 5 years ago by
- Status changed from new to needs_review
comment:3 Changed 5 years ago by
comment:4 Changed 5 years ago by
I've added the doctests you requested.
Best,
Travis
comment:5 Changed 5 years ago by
Great. Change "a mutable copies" (line 135) and I'll give it a positive review.
comment:6 Changed 5 years ago by
Done. I also changed the hash test to a better formatted test.
Changed 5 years ago by
comment:7 Changed 5 years ago by
- Reviewers set to John Palmieri
- Status changed from needs_review to positive_review
comment:8 Changed 5 years ago by
Thank you for the review.
comment:9 Changed 5 years ago by
- Merged in set to sage-5.8.beta2
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
This looks pretty good. I think it should be documented in one more place, maybe in the top-level docstring, in the mutability section, say around line 133.