Changes between Initial Version and Version 1 of Ticket #14138, comment 18


Ignore:
Timestamp:
02/20/13 01:57:36 (8 years ago)
Author:
ppurka
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14138, comment 18

    initial v1  
    1 @nthiery: This ticket is mostly orthogonal in functionality to the work in #14019. Most of the changes are in combinat.py which is largely untouched by that ticket. This ticket should not be based on #14019.
     1@nthiery: This ticket is mostly orthogonal in functionality to the work in #13605. Most of the changes are in combinat.py which is largely untouched by that ticket. This ticket should not be based on #13605.
    22
    33About `min_part=0` - the warning has been present since early 2009. That's nearly four years. I think it is about time it should either be allowed to have this ''value 0'' in the parameter, or be deprecated. There are no doctests/examples in the file which show ''when'' it produces wrong results. If the user has no idea when this gives correct results or when it gives wrong results, it should be removed.
    44
    5 Please set this back to positive review, unless there are more compelling reasons to base it on #14019.
     5Please set this back to positive review, unless there are more compelling reasons to base it on #13605.
     6
     7'''Edit''': Refer to correct ticket #13605 instead of #14019