Opened 6 years ago

Closed 6 years ago

#14137 closed enhancement (fixed)

CartanMatrix class

Reported by: stumpc5 Owned by: sage-combinat
Priority: major Milestone: sage-5.11
Component: combinatorics Keywords: cartan matrix, days45, days49
Cc: sage-combinat, nthiery, erichmond@…, tscrim Merged in: sage-5.11.beta2
Authors: Travis Scrimshaw Reviewers: Ben Salisbury
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #2023 #14314 #14673 Stopgaps:

Description (last modified by tscrim)

A class for Cartan matrices

Apply trac_14137-cartan_matrix_class-ts.patch​

Attachments (3)

cartan_matrix.py​ (7.8 KB) - added by stumpc5 6 years ago.
trac_14137-cartan_matrix_class-ts.2.patch​ (24.6 KB) - added by tscrim 6 years ago.
trac_14137-cartan_matrix_class-ts.patch​ (26.2 KB) - added by tscrim 6 years ago.

Download all attachments as: .zip

Change History (13)

Changed 6 years ago by stumpc5

comment:1 Changed 6 years ago by tscrim

  • Cc tscrim added
  • Keywords days45 added; sagedays45 removed

comment:2 follow-up: Changed 6 years ago by tscrim

Are you trying to factor this part out of #11187?

comment:3 in reply to: ↑ 2 Changed 6 years ago by stumpc5

Replying to tscrim:

Are you trying to factor this part out of #11187?

Yes -- if you want, you are very welcome to take it over!

comment:4 Changed 6 years ago by tscrim

  • Authors set to Travis Scrimshaw
  • Cc sage-combinat nthiery added
  • Dependencies set to #2023 #14314
  • Description modified (diff)
  • Status changed from new to needs_review

Changed 6 years ago by tscrim

comment:5 Changed 6 years ago by tscrim

  • Description modified (diff)

New version of the patch.

For patchbot:

Apply: trac_14137-cartan_matrix_class-ts.2.patch

comment:6 Changed 6 years ago by tscrim

  • Description modified (diff)

Made some tweaks to fix doctests.

For patchbot:

Apply: trac_14137-cartan_matrix_class-ts.patch

comment:7 Changed 6 years ago by tscrim

  • Dependencies changed from #2023 #14314 to #2023 #14314 #14673

Rebased over #14673.

Apply: trac_14137-cartan_matrix_class-ts.patch

Changed 6 years ago by tscrim

comment:8 Changed 6 years ago by tscrim

  • Keywords days49 added

New version which fixes some bugs Ben found.

Apply: trac_14137-cartan_matrix_class-ts.patch

comment:9 Changed 6 years ago by bsalisbury1

  • Reviewers set to Ben Salisbury
  • Status changed from needs_review to positive_review

comment:10 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.11.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.