Opened 4 years ago

Closed 4 years ago

#14130 closed enhancement (fixed)

Implement Crystals of Generalized Young Walls

Reported by: bsalisbury1 Owned by: bsalisbury1
Priority: major Milestone: sage-5.8
Component: combinatorics Keywords: crystal, generalized Young wall, days45
Cc: tscrim, sage-combinat Merged in: sage-5.8.beta3
Authors: Lucas David-Roesler, Ben Salisbury Reviewers: Travis Scrimshaw, Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #14052 Stopgaps:

Description (last modified by jdemeyer)

Implements the crystal B(\infty) and B(\lambda), for a highest weight \lambda, in terms of generalized Young walls in affine type A_n{(1)}.


Apply trac_14130-gyw-bs.patch

Attachments (1)

trac_14130-gyw-bs.patch (34.0 KB) - added by bsalisbury1 4 years ago.

Download all attachments as: .zip

Change History (22)

comment:1 Changed 4 years ago by bsalisbury1

  • Status changed from new to needs_review

comment:2 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

Looks good to me.

For patchbot:

Apply: trac_14130-gyw-bw.2.patch

comment:3 follow-up: Changed 4 years ago by tscrim

  • Description modified (diff)

comment:4 in reply to: ↑ 3 Changed 4 years ago by aschilling

We discussed a couple more small changes that Ben is going to implement.

comment:5 Changed 4 years ago by bsalisbury1

  • Description modified (diff)

For patchbot:

Apply: trac_14130-gyw-bs.patch

Last edited 4 years ago by bsalisbury1 (previous) (diff)

comment:6 Changed 4 years ago by bsalisbury1

  • Description modified (diff)

comment:7 Changed 4 years ago by aschilling

  • Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Anne Schilling

comment:8 Changed 4 years ago by tscrim

Hey Ben,

One small doc thing slipped past me in the new patch; on line 18, you have

    Does not work with :funct:`TensorProductOfCrystals`.

but the link should be :func:`TensorProductOfCrystals`. Could you repost the patch with this change please?

Thanks,
Travis

comment:9 Changed 4 years ago by jdemeyer

  • Status changed from positive_review to needs_work

comment:10 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:11 Changed 4 years ago by bsalisbury1

  • Status changed from needs_work to positive_review

Made appropriate change.

Travis looked over the patch.

comment:12 Changed 4 years ago by jdemeyer

  • Merged in set to sage-5.8.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:13 Changed 4 years ago by jdemeyer

  • Merged in sage-5.8.beta1 deleted
  • Resolution fixed deleted
  • Status changed from closed to new

The LaTeX PDF documentation fails to build with this patch.

comment:14 follow-up: Changed 4 years ago by bsalisbury1

  • Status changed from new to needs_review

comment:15 in reply to: ↑ 14 Changed 4 years ago by aschilling

Hi Ben,

I just pushed some changes to your patch to the sage-combinat queue (since there were trailing white spaces). Please pull from there to get them .

Also, for the very last method "subcrystal" could you please add a description.

Other than that the patch looks good to me. Once you make the change and are happy with my changes, please upload on trac and set a positive review on my behalf!

Anne

comment:16 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review

Looks good to me too. Thanks.

comment:17 Changed 4 years ago by jdemeyer

  • Status changed from positive_review to needs_work

The LaTeX PDF documentation still fails to build:

! Misplaced \omit.
\math@cr@@@ ...@ \@ne \add@amps \maxfields@ \omit
                                                  \kern -\alignsep@ \iftag@ ...
l.96848 \end{gather}

?
! Emergency stop.
\math@cr@@@ ...@ \@ne \add@amps \maxfields@ \omit
                                                  \kern -\alignsep@ \iftag@ ...
l.96848 \end{gather}

!  ==> Fatal error occurred, no output PDF file produced!
Transcript written on combinat.log.

comment:18 Changed 4 years ago by jdemeyer

  • Work issues set to docpdf

Changed 4 years ago by bsalisbury1

comment:19 Changed 4 years ago by bsalisbury1

  • Status changed from needs_work to needs_review

comment:20 Changed 4 years ago by tscrim

  • Status changed from needs_review to positive_review
  • Work issues docpdf deleted

The problem was that the pdf docbuild did not like the align* environment inside of a .. MATH:: but the html build worked just fine with this. This has been fixed for sure now.

comment:21 Changed 4 years ago by jdemeyer

  • Merged in set to sage-5.8.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.