Opened 7 years ago

Closed 7 years ago

#14128 closed defect (fixed)

Very bad mistakes in linear_arboricity

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.8
Component: graph theory Keywords:
Cc: dcoudert Merged in: sage-5.8.beta1
Authors: Nathann Cohen Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

linear_arboricity has a parameter k which appears to define the number of colors, but does not. This patch renames is to plus_one. Plus the function did not compute the decomposition with a minimum number of colors. Plus Andrew Juell reported "a counter example to a very old conjecture" which turns out to be a Sage bug ! Too bad :-)

Nathann

Attachments (1)

trac_14128.patch (5.6 KB) - added by ncohen 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by ncohen

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to needs_work

The patch is working but you could change the following text

  • "plus_one` (integer) -- the number of colors to use."

comment:3 Changed 7 years ago by ncohen

  • Status changed from needs_work to needs_review

What about that ? :-)

Nathann

Changed 7 years ago by ncohen

comment:4 Changed 7 years ago by dcoudert

  • Status changed from needs_review to positive_review

Much better !

comment:5 Changed 7 years ago by ncohen

Thaaaaaaaaaaaaaaanks !!

Nathann

comment:6 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.8.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.