Opened 6 years ago

Closed 6 years ago

#14122 closed enhancement (fixed)

Tournament and directed path constructors

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.8
Component: graph theory Keywords:
Cc: dcoudert Merged in: sage-5.8.beta1
Authors: Nathann Cohen Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Implements a constructor for Tournament and directed paths. This may be useful in #14099.

Attachments (1)

trac_14122.patch (4.7 KB) - added by ncohen 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by ncohen

  • Status changed from new to needs_review

comment:2 Changed 6 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to needs_work

Some remarks:

  • Returns the De Bruijn diraph with parameters k,n. -> Returns the De Bruijn digraph with parameters k,n.
  • in both functions, the statement g = DiGraph() should be after the test on n
  • Returns a tournament n vertices. -> Returns a tournament on n vertices. (twice in patch)
  • for i in range(n) -> for i in range(n-1)
  • d = {i:(i,0) for i in range(n)}
    g.set_pos(d)
    -> g.set_pos( {i:(i,0) for i in range(n)} )

comment:3 Changed 6 years ago by ncohen

  • Status changed from needs_work to needs_review

Hahahaha. It all makes sense. Thank you ! :-)

Nathann

comment:4 Changed 6 years ago by dcoudert

  • Status changed from needs_review to positive_review

The patch is working (install, tests, docbuild) and good to go.

comment:5 Changed 6 years ago by ncohen

Thaaaaaaaaaanks ! :-)

Nathann

comment:6 Changed 6 years ago by jdemeyer

  • Status changed from positive_review to needs_work

The patch needs a proper commit message.

Changed 6 years ago by ncohen

comment:7 Changed 6 years ago by ncohen

  • Status changed from needs_work to positive_review

Argggggg ! I knew that I had forgotten a commit message in some ticket ! Sorryyyyyyyy ^^;

Nathann

comment:8 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.8.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.