Remove CombinatorialClass from skew*

[tscrim]

Removing CombinatorialClass from combinat/skew_partition.py and combinat/skew_tableau.py.

Part of #12913.

---

Apply: trac_14101-remove_cc_skew-ts.patch​

[tscrim]

The dependency on #14772 is some fuzz due to editing of cython files in symmetrica.

[tscrim]

There is a minor dependency in integer_vector_weighted.py from #13589.

[tscrim]

Removed fuzz caused by #14907 (I think).

[tscrim]

I also fixed the error with SkewTableau.to_chain().

[tscrim]

Fixed corner case of to_chain(). Thanks for catching that Mike.

[darij]

still unfinished review patch

[darij]

OOPS wrong thread, sorry!

[tscrim]

For patchbot:

Apply: trac_14101-remove_cc_skew-ts.patch

[darij]

1) Why does this depend on #14907?

2)

sage -t devel/sage-main/sage/combinat/ribbon_tableau.py
**********************************************************************
File "devel/sage-main/sage/combinat/ribbon_tableau.py", line 201, in sage.combinat.ribbon_tableau.RibbonTableaux
Failed example:
    for i in R: i.pp(); print
Expected:
      .  .  0  0  0
      .  0  0  2
      1  0  1
Got:
      .  .  0  0  0
      .  0  0  2
      1  0  1
    <BLANKLINE>
      .  .  1  0  0
      .  0  0  0
      1  0  2
    <BLANKLINE>
      .  .  0  0  0
      .  1  0  1
      2  0  0
    <BLANKLINE>
**********************************************************************

This seems to be a bug with the doctesting framework, which thinks of empty lines as EOM. Just replacing "print" by "print 'some_nonempty_string'" does the trick.

[tscrim]

Fixed the above (all one has to do was add <BLANKLINE>) and added the comment that Arthur and I talked about via email.

For patchbot:

Apply: trac_14101-remove_cc_skew-ts.patch

[darij]

The doctest works now; positive review then?

[tscrim]

Arthur had wanted me to change some documentation, so he'll set the positive review once he's looked that over.

[tscrim]

Thanks for doing the final review Arthur.

[alubovsky]

Travis,

No problem. Thanks for your help.

[jferreira]

There is fuzz applying to 5.11.beta3

applying trac_14101-remove_cc_skew-ts.patch
patching file sage/combinat/tableau.py
Hunk #10 succeeded at 1486 with fuzz 2 (offset -52 lines).
now at: trac_14101-remove_cc_skew-ts.patch

None of the dependencies touch tableau.py. Can you please rebase to see if that will fix the fuzz?

Thanks, Jeff

[tscrim]

Try it with #7983. I'm not getting any fuzz (in the combinat queue).

[jferreira]

Travis,

Yes that worked. It now applies without any fuzz. Thanks.

Jeff

[tscrim]

Thanks for catching that Jeff.

[jferreira]

I get a warning when building the doc:

[combinat ] /Applications/sage/local/lib/python2.7/site-packages/sage/combinat/ribbon_tableau.py:docstring of sage.combinat.ribbon_tableau.RibbonTableau:23: WARNING: Literal block expected; none found.

[tscrim]

I've fixed the offending docstring.

For patchbot:

Apply: trac_14101-remove_cc_skew-ts.patch

[tscrim]

Trivial rebase over changes in sources.py in #14772.