Opened 6 years ago
Closed 6 years ago
#14081 closed defect (fixed)
Solve bug in BraidGroup
Reported by: | mmarco | Owned by: | joyner |
---|---|---|---|
Priority: | major | Milestone: | sage-5.9 |
Component: | group theory | Keywords: | |
Cc: | jdemeyer, vbraun | Merged in: | sage-5.9.beta4 |
Authors: | Miguel Marco | Reviewers: | Travis Scrimshaw, Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
BraidGroup? checks that the number of generators is bigger or equal than 2. It should be 1 (two strands, one generator). So, now the braid group on two strands can't be created.
This patch solves it. (It is just a one line change):
Apply: 14081_one_generator.patch and 14081_one_generator2.patch
Attachments (2)
Change History (12)
comment:1 Changed 6 years ago by
- Reviewers set to Travis Scrimshaw
Changed 6 years ago by
comment:2 Changed 6 years ago by
- Status changed from new to needs_review
Apply 14981_one_generator.patch
comment:3 Changed 6 years ago by
- Description modified (diff)
comment:4 Changed 6 years ago by
For the patchbot:
Apply 14081_one_generator.patch
comment:5 Changed 6 years ago by
- Description modified (diff)
There's also a doctest failure (due to capitalization). Also, for the doctest, could you make it some form of:
Check that :trac:`14081` is fixed:: sage: BraidGroup(2) Braid group on 2 strands sage: BraidGroup(('a',)) Braid group on 2 strands
Thanks.
Changed 6 years ago by
comment:6 Changed 6 years ago by
- Description modified (diff)
comment:7 Changed 6 years ago by
- Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Volker Braun
- Status changed from needs_review to positive_review
Looks good to me
comment:8 Changed 6 years ago by
Same. Thank you for your work Miguel and the final review Volker.
comment:9 Changed 6 years ago by
- Description modified (diff)
comment:10 Changed 6 years ago by
- Merged in set to sage-5.9.beta4
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Could you add a doctest showing this is fixed and a comment on that about about why it should be
n < 1
instead ofn < 2
as the error message (correctly) indicates (such as# n now is the number of generators
)? Once that is done, set this to needs_review.Thanks,
Travis