Opened 8 years ago
Closed 5 years ago
#14064 closed defect (fixed)
Matrix.subdivide goes haywire if indices are not in increasing order
Reported by:  Bouillaguet  Owned by:  Bouillaguet 

Priority:  major  Milestone:  sage7.3 
Component:  linear algebra  Keywords:  beginner, sd75 
Cc:  Merged in:  
Authors:  Fangan Dosso  Reviewers:  Édouard Rousseau, Turku Ozlum Celik 
Report Upstream:  N/A  Work issues:  
Branch:  10460b4 (Commits, GitHub, GitLab)  Commit:  10460b458991481f175c9aec0ef8a9523872f303 
Dependencies:  Stopgaps: 
Description (last modified by )
sage: M = identity_matrix(5) sage: M.subdivide([4,1], [3,2]) sage: M [1 000 0] [++] [0 100 0] [0 010 0] [0 001 0] [++] [0 000 1] sage: M.subdivision(1,1) []
This is broken, and there is an easy fix.
Change History (21)
comment:1 Changed 8 years ago by
 Milestone changed from sage5.11 to sage5.12
comment:2 Changed 7 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:3 Changed 7 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:4 Changed 7 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:5 Changed 5 years ago by
 Keywords trivial added
comment:6 Changed 5 years ago by
 Keywords trivial removed
 Milestone changed from sage6.4 to sage7.3
comment:7 Changed 5 years ago by
 Keywords beginner sd75 added
 Owner changed from jason, was to Bouillaguet
comment:8 Changed 5 years ago by
 Description modified (diff)
comment:9 Changed 5 years ago by
 Branch set to u/fdosso48/bug_in_subdivide
comment:10 Changed 5 years ago by
 Commit set to 60752486adc1cd7490a748f28f45ed2b43c309a8
The 'subdivide' method just needed its inputs sorted to work correctly.
New commits:
6075248  Fixed a bug related to subdivide method

comment:11 Changed 5 years ago by
 Status changed from new to needs_review
comment:12 Changed 5 years ago by
 Status changed from needs_review to needs_work
The fix seems to work as expected. Could you please:
 Add your real name in the "Author" Field of the ticket
 Improve the documentation of the function (as discussed)
 Add a doctest enforcing that the problem is fixed
After that, the tickets get a positive review (if the patchbot agrees).
comment:13 Changed 5 years ago by
comment:14 Changed 5 years ago by
 Commit changed from 60752486adc1cd7490a748f28f45ed2b43c309a8 to 10460b458991481f175c9aec0ef8a9523872f303
comment:15 Changed 5 years ago by
 Status changed from needs_work to needs_review
comment:16 Changed 5 years ago by
Hi,
I went through the reviewer's checklist and everything looked fine.
Édouard
comment:17 followup: ↓ 19 Changed 5 years ago by
Then you should add you full name to the "Reviewers" field of the ticket, and mark it as "positive_review"
comment:18 Changed 5 years ago by
 Reviewers set to Édouard Rousseau
 Status changed from needs_review to positive_review
As I said just a little above, everything seemed fine.
Giving it a positive review.
Édouard
comment:19 in reply to: ↑ 17 Changed 5 years ago by
Replying to Bouillaguet:
Then you should add you full name to the "Reviewers" field of the ticket, and mark it as "positive_review"
OK, that's done.
comment:20 Changed 5 years ago by
 Reviewers changed from Édouard Rousseau to Édouard Rousseau, Turku Ozlum Celik
I checked the ticket by following the reviewer's checklist. It seems that is OK. Positive review.
comment:21 Changed 5 years ago by
 Branch changed from u/fdosso48/bug_in_subdivide to 10460b458991481f175c9aec0ef8a9523872f303
 Resolution set to fixed
 Status changed from positive_review to closed
It would be good for you to provide a fix!