Opened 10 years ago
Closed 10 years ago
#14063 closed enhancement (fixed)
Remove CombinatorialClass from Compositions
Reported by: | Travis Scrimshaw | Owned by: | Sage Combinat CC user |
---|---|---|---|
Priority: | major | Milestone: | sage-5.8 |
Component: | combinatorics | Keywords: | deprecation |
Cc: | Sage Combinat CC user, Nicolas M. Thiéry | Merged in: | sage-5.8.beta2 |
Authors: | Travis Scrimshaw | Reviewers: | Vincent Delecroix |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14065 | Stopgaps: |
Description
Part of #12913.
Attachments (1)
Change History (15)
comment:1 Changed 10 years ago by
Authors: | → Travis Scrimshaw |
---|---|
Cc: | Nicolas M. Thiéry added |
Dependencies: | → #14065 |
Status: | new → needs_review |
comment:2 Changed 10 years ago by
comment:3 Changed 10 years ago by
Comments on the doc in composition.py
- line 786: list(Compositions(4)) may be replaced with Compositions(4).list() (idem lines 877, 882, 927)
- line 844: there is a strange sharp at the end of the line
- line 859: a space is missing
comment:6 Changed 10 years ago by
Milestone: | sage-5.7 → sage-5.8 |
---|---|
Reviewers: | → Vincent Delecroix |
comment:7 Changed 10 years ago by
How was this patch file created, as some headers are missing? You should use hg export [tip]
.
comment:9 Changed 10 years ago by
Merged in: | → sage-5.8.beta1 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:10 Changed 10 years ago by
Merged in: | sage-5.8.beta1 |
---|---|
Resolution: | fixed |
Status: | closed → new |
The LaTeX documentation doesn't build because you use backslashes inside the
def cardinality(self): """ """
docstring instead of
def cardinality(self): r""" """
comment:11 Changed 10 years ago by
Status: | new → needs_review |
---|
Made the fixes (I put it in a few other places as well). I'll double/triple-check over the compiled docbuild once it finishes the rebuild.
comment:12 Changed 10 years ago by
I also fixed a broken link. Jeroen, would it be okay if I set this back to positive review?
Sorry about this,
Travis
Changed 10 years ago by
Attachment: | trac_14063-remove_cc_compositions-ts.patch added |
---|
Fixed docstrings
comment:13 Changed 10 years ago by
Status: | needs_review → positive_review |
---|
I'm setting this back to positive review...I hope that's okay...
comment:14 Changed 10 years ago by
Merged in: | → sage-5.8.beta2 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Hi,
The rest looks good.
Vincent