Changes between Initial Version and Version 1 of Ticket #14054, comment 28


Ignore:
Timestamp:
02/23/13 22:56:39 (7 years ago)
Author:
SimonKing
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14054, comment 28

    initial v1  
    66> (shouldn't `__call__` be a little more permissive about its arguments by the way? Certainly, an error would be more appropriate than an assert if this is something that actually can go wrong)
    77
    8 No, I think an assertion is the right thing to here. Perhaps one could provide the assertion with an error message that names the two parents that don't much. In that way, we could at least see what two parents are involved.
     8No, I think an assertion is the right thing to do here. Perhaps one could provide the assertion with an error message that names the two parents that don't match. In that way, we could at least see what two parents are involved.
    99
    1010Note that my patch changes `CombinatorialFreeModule` from `UniqueRepresentation` to `CachedRepresentation`, since it overrides the equality tests. So, it could actually be that the two parents are genuinely non-unique. And since a cached_method is involved here, which does comparison by equality and not identity, we could really be in trouble here.