Opened 8 years ago

Closed 7 years ago

#14050 closed defect (fixed)

Cleaning up docs in Finite Coxeter Groups

Reported by: knsam Owned by: mvngu
Priority: trivial Milestone: sage-6.2
Component: documentation Keywords: beginner, coxeter
Cc: tscrim Merged in:
Authors: Kannappan Sampath, Frédéric Chapoton Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 24cc315 (Commits) Commit: 24cc315d210b90d392bd01519fb1b5bb9f7175ac
Dependencies: Stopgaps:

Description

There are a couple of things to fix in the documentation of Finite Coxeter Groups, like:

#. Codifying self, True, False and so on... #. The recursive algorithm in the docstring of method bruhat_upper_covers needs fixing.

Minor "defects" but will improve consistency.

Attachments (1)

trac_14050_minor_v0.patch (2.2 KB) - added by knsam 8 years ago.
Attaching V0. See Comments.

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by knsam

Attaching V0. See Comments.

comment:1 Changed 8 years ago by knsam

  • Status changed from new to needs_info

There are some other things we could fix: I think we could take this ticket to fix some of the todos in this ticket. I need help from you guys. For a start, I'd like to fix the name for the method long_element.

I'll do the other to-dos in a short while (two weeks) and post a patch.

~KnS

comment:2 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:3 Changed 7 years ago by chapoton

  • Branch set to u/chapoton/14050
  • Commit set to 24cc315d210b90d392bd01519fb1b5bb9f7175ac

New commits:

24cc315Trac 14050: Fixed messy formatting.

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:5 Changed 7 years ago by chapoton

  • Status changed from needs_info to needs_review

I propose to just use this ticket for the trivial correction already in the commits.

comment:6 Changed 7 years ago by chapoton

  • Cc tscrim added
  • Keywords coxeter added

comment:7 Changed 7 years ago by chapoton

  • Authors set to knsam, Frédéric Chapoton

comment:8 Changed 7 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

Good !

Nathann

comment:9 Changed 7 years ago by tscrim

  • Authors changed from knsam, Frédéric Chapoton to Kannappan Sampath, Frédéric Chapoton

comment:10 Changed 7 years ago by vbraun

  • Branch changed from u/chapoton/14050 to 24cc315d210b90d392bd01519fb1b5bb9f7175ac
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.