Opened 9 years ago
Closed 9 years ago
#14039 closed enhancement (duplicate)
Gap 4.6.3 upgrade
Reported by: | vbraun | Owned by: | tbd |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | packages: standard | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | Travis Scrimshaw | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14014 | Stopgaps: |
Description (last modified by )
And now MPIR defines __GNU_MP_RELEASE
so the __GMP_MP_RELEASE
hack is not needed anymore here or in gap spkg.
- GAP spkg: http://sage.math.washington.edu/home/vbraun/spkg/gap-4.6.3.p0.spkg
- LibGAP spkg: http://sage.math.washington.edu/home/vbraun/spkg/libgap-4.6.3.p0.spkg
- http://sage.math.washington.edu/home/vbraun/spkg/gap_packages-4.6.3.spkg
- http://sage.math.washington.edu/home/vbraun/spkg/database_gap-4.6.3.spkg
- Apply trac_14039_doctest_fixes.patch to the Sage library
Attachments (1)
Change History (27)
comment:1 Changed 9 years ago by
- Component changed from group theory to packages
- Description modified (diff)
- Milestone changed from sage-5.8 to sage-5.9
- Owner changed from joyner to tbd
- Summary changed from Gap 4.6.0 upgrade to Gap 4.6.2 upgrade
comment:2 Changed 9 years ago by
comment:3 Changed 9 years ago by
comment:4 Changed 9 years ago by
- Description modified (diff)
comment:5 Changed 9 years ago by
Volker, any idea what to do about this:
sage -t "devel/sage/sage/groups/libgap_wrapper.pyx" An error occurred, but libGAP has no handler set. Error message: An error occurred, but libGAP has no handler set. Error message: ********************************************************************** File "/release/merger/sage-5.8.beta4/devel/sage/sage/groups/libgap_wrapper.pyx", line 12: sage: from sage.groups.libgap_wrapper import ElementLibGAP, ParentLibGAP Exception raised: Traceback (most recent call last): File "/release/merger/sage-5.8.beta4/local/bin/ncadoctest.py", line 1231, in run_one_test self.run_one_example(test, example, filename, compileflags) File "/release/merger/sage-5.8.beta4/local/bin/sagedoctest.py", line 38, in run_one_example OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags) File "/release/merger/sage-5.8.beta4/local/bin/ncadoctest.py", line 1172, in run_one_example compileflags, 1) in test.globs File "<doctest __main__.example_0[2]>", line 1, in <module> from sage.groups.libgap_wrapper import ElementLibGAP, ParentLibGAP###line 12: sage: from sage.groups.libgap_wrapper import ElementLibGAP, ParentLibGAP File "libgap_wrapper.pyx", line 62, in init sage.groups.libgap_wrapper (sage/groups/libgap_wrapper.c:5712) File "libgap.pyx", line 574, in init sage.libs.gap.libgap (sage/libs/gap/libgap.c:4203) File "libgap.pyx", line 395, in sage.libs.gap.libgap.Gap.__init__ (sage/libs/gap/libgap.c:2747) File "util.pyx", line 215, in sage.libs.gap.util.initialize (sage/libs/gap/util.c:3538) RuntimeError: libGAP initialization failed You are running a GAP kernel which does not fit with the library. Probably you forgot to apply the kernel part or the library part of a bugfix? If you are using Windows, make sure you installed the file wbin4r6n2.zoo (or .zip), Macintosh users make sure the file bin4r6n2-PPC.sit (or -68k.sit) is installed, Unix users please recompile. Error before error-handling is initialized: Update to correct kernel version! #W Static module lib/oper1.g has CRC mismatch, ignoring Error before error-handling is initialized: **********************************************************************
Running ./sage -b
doesn't really do much, could there be some dependencies missing?
comment:6 follow-up: ↓ 7 Changed 9 years ago by
LibGAP needs to be kept in sync since it uses the GAP library from the stand-alone GAP install. I can update libgap...
comment:7 in reply to: ↑ 6 Changed 9 years ago by
Replying to vbraun:
LibGAP needs to be kept in sync since it uses the GAP library from the stand-alone GAP install. I can update libgap...
OK, sounds good.
comment:8 Changed 9 years ago by
- The
gap_packages
anddatabase_gap
spkgs might need to be updated. - Changes are not checked in
comment:9 Changed 9 years ago by
- Description modified (diff)
I've added the corresponding libgap spkg. I didn't make any real changes, only applied the GAP 4.5.7->4.6.2 diffs.
comment:10 Changed 9 years ago by
- Description modified (diff)
comment:11 Changed 9 years ago by
For the record: I based the libgap spkg on the libgap version that awaits review at #14014.
There are a few doctests that fail because of changed GAP notation for some group elements.
comment:12 Changed 9 years ago by
- Dependencies set to #14014
comment:13 Changed 9 years ago by
- Description modified (diff)
comment:14 Changed 9 years ago by
- Summary changed from Gap 4.6.2 upgrade to Gap 4.6.3 upgrade
Does this really depend on #14014? If not, could you upgrade the libGAP spkg to 4.6.3?
comment:15 Changed 9 years ago by
- Description modified (diff)
comment:16 follow-up: ↓ 18 Changed 9 years ago by
gap, libgap, database_gap, and gap_packages must be kept in sync.
comment:17 Changed 9 years ago by
- Description modified (diff)
comment:18 in reply to: ↑ 16 Changed 9 years ago by
Replying to vbraun:
gap, libgap, database_gap, and gap_packages must be kept in sync.
Sure. I can do all packages except for libGAP.
comment:19 Changed 9 years ago by
The patch depends on #14014
comment:20 Changed 9 years ago by
- Description modified (diff)
comment:21 Changed 9 years ago by
- Description modified (diff)
The siginterrupt.patch has been upstreamed
comment:22 Changed 9 years ago by
- Status changed from new to needs_review
All doctests pass for me...
comment:23 Changed 9 years ago by
I combined those packages and patches with those of ticket #14014, and things compile and doctest (except the quadratic forms ones which fail on this box anyway).
I'm not sure I can give a positive review though: the patches change the result of many tests, and I have no idea if they really replace a correct value by another correct value...
comment:24 Changed 9 years ago by
- Milestone changed from sage-5.10 to sage-duplicate/invalid/wontfix
Superseded by #14682
comment:25 Changed 9 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
comment:26 Changed 9 years ago by
- Resolution set to duplicate
- Status changed from positive_review to closed
Would this require also an upgrade of
gap_packages
?