Opened 7 years ago

Closed 7 years ago

#14033 closed defect (fixed)

Let Singular link to termcap on Cygwin

Reported by: jpflori Owned by: tbd
Priority: major Milestone: sage-5.8
Component: porting: Cygwin Keywords: cygwin spkg singular
Cc: kcrisman, dimpase Merged in: sage-5.8.beta0
Authors: Jean-Pierre Flori Reviewers: Dmitrii Pasechnik
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jpflori)

In Singular/Makefile?.in there is specific treatment no to link directly to libm but as a counterpart the other needed libs are hardcoded rather than deduced from the autotools NEED_LIBS variable. And these hardcoded libs include ncurses rather than termcap (which we provided, is correctly detected by configure and put in NEED_LIBS and used on other oses).

Reported usptream as http://www.singular.uni-kl.de:8002/trac/ticket/476#ticket .

Use spkg at http://boxen.math.washington.edu/home/jpflori/singular-3-1-5.p4.spkg

Attachments (1)

singular-3-1-5.p4.diff (1.9 KB) - added by jpflori 7 years ago.
Spkg diff, for review only.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by jpflori

  • Description modified (diff)
  • Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.

comment:2 Changed 7 years ago by jpflori

That might be fixed in further Singular releases which switched to automake for the Singular folder.

comment:3 Changed 7 years ago by jpflori

This might be mitigated by #12725 and in future autotools based upstream version but is worth the inclusion I guess.

comment:4 Changed 7 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Description modified (diff)
  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.
  • Status changed from new to needs_review

comment:5 Changed 7 years ago by dimpase

  • Status changed from needs_review to positive_review

comment:6 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.7 to sage-5.8
  • Reviewers set to Dmitrii Pasechnik

comment:7 Changed 7 years ago by jdemeyer

  • Status changed from positive_review to needs_work

Typo in SPKG.txt:

singular-3.1.5.p4

should be

singular-3-1-5.p4

Changed 7 years ago by jpflori

Spkg diff, for review only.

comment:8 Changed 7 years ago by jpflori

  • Status changed from needs_work to positive_review

Updated the spkg and put this back to positive_review as the fix is more than trivial.

comment:9 Changed 7 years ago by jdemeyer

  • Status changed from positive_review to needs_info

Could you please confirm that this new spkg is still needed, given #12725?

comment:10 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.8.beta0
  • Resolution set to fixed
  • Status changed from needs_info to closed
Note: See TracTickets for help on using tickets.