Opened 9 years ago

Closed 9 years ago

#14027 closed defect (fixed)

Disable sage-make_relative when upgrading

Reported by: jdemeyer Owned by: GeorgSWeber
Priority: blocker Milestone: sage-5.7
Component: build Keywords:
Cc: Merged in: sage-5.7.beta2
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

This is essentially #13407 for upgrades: sage-make_relative is evil because it leads to race conditions.

This probably caused an upgrade problem on rosemary: the script local/bin/ipython wasn't installed:

running install_scripts
copying build/scripts-2.7/iplogger -> /home/buildbot/build/sage/rosemary-1/rosemary_upgrade_4.5.2/build/sage-5.7.beta1/local/bin

which normally looks like

running install_scripts
copying build/scripts-2.7/ipengine -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipcontroller -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipcluster -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/iplogger -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipython -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/pycolor -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/irunner -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/iptest -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin

Distutils by default doesn't overwrite newer files, and sage-make_relative can make a file look newer, causing distutils to not copy a file.

Attachments (1)

14027_dont_make_relative.patch (658 bytes) - added by jdemeyer 9 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)

comment:2 Changed 9 years ago by jdemeyer

  • Description modified (diff)

Changed 9 years ago by jdemeyer

comment:3 Changed 9 years ago by jdemeyer

  • Status changed from new to needs_review

comment:4 Changed 9 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Sounds good to me.

comment:5 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.7.beta2

comment:6 Changed 9 years ago by jdemeyer

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.