Opened 9 years ago

Closed 9 years ago

#14026 closed defect (fixed)

PolyBoRi should depend on IPython

Reported by: jdemeyer Owned by: GeorgSWeber
Priority: minor Milestone: sage-5.9
Component: build Keywords:
Cc: vbraun Merged in: sage-5.9.beta1
Authors: Jeroen Demeyer Reviewers: Alexander Dreyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

PolyBoRi contains an IPython-based shell (ipbori). spkg/standard/deps should reflect this.

Attachments (1)

14026_polybori_deps.patch​ (919 bytes) - added by jdemeyer 9 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by jdemeyer

  • Description modified (diff)

Changed 9 years ago by jdemeyer

comment:2 Changed 9 years ago by jdemeyer

  • Status changed from new to needs_review

comment:3 Changed 9 years ago by jdemeyer

  • Cc vbraun added
  • Priority changed from blocker to critical

I'm not entirely sure this patch is really needed, but it can't possibly hurt.

comment:4 Changed 9 years ago by jdemeyer

  • Priority changed from critical to minor

comment:5 Changed 9 years ago by AlexanderDreyer

Indeed, it's not needed, since ipbori can fall back to a plain python shell at runtime. But it won't hurt and ensures that the best shell is used. So positively reviewed.

comment:6 Changed 9 years ago by AlexanderDreyer

  • Status changed from needs_review to positive_review

comment:7 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.9.beta1
  • Resolution set to fixed
  • Reviewers set to Alexander Dreyer
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.