Opened 9 years ago

Closed 9 years ago

#14024 closed defect (fixed)

More IPython 0.13 fixes

Reported by: vbraun Owned by: tbd
Priority: blocker Milestone: sage-5.7
Component: packages: standard Keywords:
Cc: Merged in: sage-5.7.beta2
Authors: Volker Braun Reviewers: Keshav Kini
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

Apply trac_14024_branches.patch

Attachments (1)

trac_14024_branches.patch​ (1.9 KB) - added by vbraun 9 years ago.
Initial patch

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by jdemeyer

  • Priority changed from major to blocker

comment:2 Changed 9 years ago by jdemeyer

Another problem happens with upgrading. On rosemary (RHEL 5.6 x86_64), the scripts in local/bin aren't properly installed. In particular local/bin/ipython isn't copied and the pre-upgrade local/bin/ipython doesn't work. Full log: ​http://build.sagemath.org/sage/builders/UGA%20rosemary%20%28RHEL%205.6%20x86_64%29%20up%26nbsp%3B4.5.2/builds/53/steps/shell_7/logs/ipython

But note this part: 

running install_scripts
copying build/scripts-2.7/iplogger -> /home/buildbot/build/sage/rosemary-1/rosemary_upgrade_4.5.2/build/sage-5.7.beta1/local/bin

which normally looks like 

running install_scripts
copying build/scripts-2.7/ipengine -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipcontroller -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipcluster -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/iplogger -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipython -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/pycolor -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/irunner -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/iptest -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin

EDIT: this must have been because of a timestamp issue (Python distutils by default doesn't overwrite newer files).

Version 1, edited 9 years ago by jdemeyer (previous) (next) (diff)

Changed 9 years ago by vbraun

Initial patch

comment:3 Changed 9 years ago by vbraun

The "you are on branch X" message was implementing a third bannering system besides sage-banner and IPython banner, and I removed all of it. We can think about putting it back in after we switch to git.

Apply trac_14024_branches.patch

comment:4 Changed 9 years ago by vbraun

  • Authors set to Volker Braun
  • Description modified (diff)

comment:5 Changed 9 years ago by vbraun

  • Status changed from new to needs_review

comment:6 Changed 9 years ago by kini

  • Reviewers set to Keshav Kini

Ideally Sage itself should function even if all version control data is stripped from the installation. After we switch to git this might actually become feasible. "You are on branch X" is a nice thing to have, but it should fail gracefully. I like this patch though because the "branches" referred to by this message are not even used by anyone except the patchbot anymore.

Just testing that the patchbot succeeds in testing sage-0 on arando before I give this positive review.

comment:7 Changed 9 years ago by kini

  • Status changed from needs_review to positive_review

Works fine.

comment:8 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.7.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.