Opened 7 years ago
Closed 7 years ago
#13968 closed defect (fixed)
BooleanPolynomialSequence.eliminate_linear_variables leaves some linear equations in corner cases
Reported by: | Bouillaguet | Owned by: | malb |
---|---|---|---|
Priority: | major | Milestone: | sage-5.7 |
Component: | commutative algebra | Keywords: | |
Cc: | malb | Merged in: | sage-5.7.beta1 |
Authors: | Charles Bouillaguet | Reviewers: | Martin Albrecht |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #13847 | Stopgaps: |
Description
sage: R.<x,y,z> = BooleanPolynomialRing() sage: S = Sequence([x*y*z+x*y+z*y+x*z, x+y+z+1, x+y]) sage: S.eliminate_linear_variables(return_reductors=True) [z + 1], [x + y + z + 1])
Obviously, the first part is linear, and it shouldn't. The result should have been:
( [], [z + 1, x + y] )
Attachments (1)
Change History (10)
comment:1 Changed 7 years ago by
comment:2 Changed 7 years ago by
- Status changed from new to needs_review
comment:3 Changed 7 years ago by
a bit nitpicky but I think it should read skip is None
instead of skip==None. But I think other than that the patch looks good.
comment:4 Changed 7 years ago by
replaced == None
by
is None
comment:5 Changed 7 years ago by
- Reviewers set to Martin Albrecht
- Status changed from needs_review to positive_review
comment:6 Changed 7 years ago by
- Dependencies set to #13847
- Status changed from positive_review to needs_work
This should be rebased to #13847.
Changed 7 years ago by
comment:8 Changed 7 years ago by
- Status changed from needs_review to positive_review
comment:9 Changed 7 years ago by
- Merged in set to sage-5.7.beta1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
The patch repairs the function, along with the following changes: