#13938 closed defect (fixed)
Don't set CCACHE_DIR
Reported by: | Jeroen Demeyer | Owned by: | Georg S. Weber |
---|---|---|---|
Priority: | blocker | Milestone: | sage-5.6 |
Component: | build | Keywords: | |
Cc: | Punarbasu Purkayastha | Merged in: | sage-5.6.rc0 |
Authors: | Jeroen Demeyer | Reviewers: | R. Andrew Ohana, Punarbasu Purkayastha |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
This is a follow-up to #13032. After consulting sage-devel, it seems like a bad idea to set CCACHE_DIR
unconditionally, so let's not do this.
Blocker because #13032 is a regression for people using a system-wide ccache installation.
optional spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/ccache-3.1.9.spkg
apply: 13938_ccache_default_dir.patch to the SAGE_ROOT
repository.
Attachments (2)
Change History (14)
Changed 10 years ago by
Attachment: | 13938_ccache_default_dir.patch added |
---|
comment:1 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 10 years ago by
Description: | modified (diff) |
---|
comment:4 Changed 10 years ago by
Status: | new → needs_review |
---|
comment:5 Changed 10 years ago by
Description: | modified (diff) |
---|
Changed 10 years ago by
Attachment: | ccache-3.1.9.diff added |
---|
comment:6 Changed 10 years ago by
Status: | needs_review → needs_info |
---|
This appears to implement (1) from the sage-devel discussion, but to me it seemed like (3) was more the consensus from that thread. If (1) is the consensus, then this looks fine to me.
comment:7 Changed 10 years ago by
Yes, this implements (1). After looking at the thread again, I'd say that (1) was the consensus.
comment:8 Changed 10 years ago by
This looks good to me. I installed the spkg and the patch, and got no surprises. Tried out some small package like cliquer and it finished within 2 sec, cython took 22sec.
@ohanar: since you are the main author of the ccache ticket, I will wait for your input - if you have no objection, then set it to positive review.
comment:10 Changed 10 years ago by
Reviewers: | → R. Andrew Ohana, Punarbasu Purkayastha |
---|---|
Status: | needs_review → positive_review |
comment:11 Changed 10 years ago by
Merged in: | → sage-5.6.rc0 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Diff for the ccache spkg, for review only