Opened 9 years ago

Closed 9 years ago

#13930 closed defect (fixed)

remove bad is_subcategory implementation

Reported by: nbruin Owned by: nthiery
Priority: major Milestone: sage-5.6
Component: categories Keywords:
Cc: SimonKing Merged in: sage-5.6.rc0
Authors: Nils Bruin Reviewers: Simon King
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

As discovered on #13400, there is a bad implementation of is_subcategory in categories/covariant_functorial_construction.py: It doesn't cache although it should, it doesn't have a proper docstring and it shadows a better implementation on a superclass. It simply needs to be removed.

Attachments (1)

trac_13930-del_is_subcat.patch (1.0 KB) - added by nbruin 9 years ago.
Straightforward fix

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by nbruin

Straightforward fix

comment:1 Changed 9 years ago by nbruin

  • Authors set to Nils Bruin
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by SimonKing

  • Cc SimonKing added

comment:3 Changed 9 years ago by nbruin

Simon and Nicholas would be very qualified to review this.

comment:4 Changed 9 years ago by SimonKing

  • Reviewers set to Simon King
  • Status changed from needs_review to positive_review

We have discussed on #13400 that the removal if this is_subcat method makes sense, the change is indirectly doctested by the fact that the existing tests don't break. Hence, the patch seems fine to me.

The patchbot is happy, and I am happy as well.

comment:5 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.6.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.