Opened 9 years ago

Closed 9 years ago

#13902 closed defect (fixed)

Slowdown for PARI integer determinant

Reported by: azi Owned by: tbd
Priority: major Milestone: sage-5.6
Component: packages: standard Keywords:
Cc: jdemeyer Merged in: sage-5.6.beta3
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

There appears to be an issue in pariGP that slows down the computation of the determinant. See this sage-devel post and this PARI/GP discussion.

spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.3.p1.spkg

Attachments (1)

pari-2.5.3.p1.diff (7.3 KB) - added by jdemeyer 9 years ago.
Diff for the PARI spkg, for review only

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by jdemeyer

  • Cc jdemeyer added; jdemeyer@… removed

comment:2 Changed 9 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)

Changed 9 years ago by jdemeyer

Diff for the PARI spkg, for review only

comment:3 Changed 9 years ago by jdemeyer

  • Status changed from new to needs_review
  • Summary changed from Pari slowdown bug to Slowdown for PARI integer determinant

comment:4 Changed 9 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Looks good to me!

comment:5 Changed 9 years ago by azi

Thank you for posting the patch Jeroen!

Could someone explain to me how could I apply this patch so that I test it as well?

Best,

Jernej

comment:6 Changed 9 years ago by jdemeyer

From the sage root directory:

$ ./sage -i http://boxen.math.washington.edu/home/jdemeyer/spkg/pari-2.5.3.p1.spkg
$ ./sage -b

comment:7 Changed 9 years ago by azi

Thank you!

I haven't looked at the patch provided but I have tested it and the bug is now definitely fixed!

comment:8 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.6.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.