Opened 10 years ago

Closed 10 years ago

#13900 closed task (fixed)

Remove unused _change_ordering from `BooleanPolynomialRing`

Reported by: Alexander Dreyer Owned by: Martin Albrecht
Priority: minor Milestone: sage-5.6
Component: commutative algebra Keywords: polybori, unused code
Cc: Merged in: sage-5.6.beta3
Authors: Alexander Dreyer Reviewers: Martin Albrecht
Report Upstream: None of the above - read trac for reasoning. Work issues:
Branch: Commit:
Dependencies: #13883 Stopgaps:

Status badges

Description (last modified by Alexander Dreyer)

In #13883 the unused method _change_ordering causes problems. Since this (internal) functionality is not used anymore it should be removed.

Apply pbori_remove_change_ordering.patch

Attachments (1)

pbori_remove_change_ordering.patch (2.0 KB) - added by Alexander Dreyer 10 years ago.
Removing unused (and dangerous) _change_ordering from BooleanPolynomialRing

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Alexander Dreyer

Removing unused (and dangerous) _change_ordering from BooleanPolynomialRing

comment:1 Changed 10 years ago by Alexander Dreyer

Authors: Alexander Dreyer
Description: modified (diff)
Status: newneeds_review

_change_ordering is dead code now and can be removed without problems: pbori_remove_change_ordering.patch

Apply pbori_remove_change_ordering.patch

comment:2 Changed 10 years ago by Martin Albrecht

Reviewers: Martin Albrecht
Status: needs_reviewpositive_review

Does what it promises, if doctests pass, this patch is good.

comment:3 Changed 10 years ago by Jeroen Demeyer

Merged in: sage-5.6.beta3
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.