Opened 7 years ago

Closed 7 years ago

#13900 closed task (fixed)

Remove unused _change_ordering from `BooleanPolynomialRing`

Reported by: AlexanderDreyer Owned by: malb
Priority: minor Milestone: sage-5.6
Component: commutative algebra Keywords: polybori, unused code
Cc: Merged in: sage-5.6.beta3
Authors: Alexander Dreyer Reviewers: Martin Albrecht
Report Upstream: None of the above - read trac for reasoning. Work issues:
Branch: Commit:
Dependencies: #13883 Stopgaps:

Description (last modified by AlexanderDreyer)

In #13883 the unused method _change_ordering causes problems. Since this (internal) functionality is not used anymore it should be removed.

Apply pbori_remove_change_ordering.patch

Attachments (1)

pbori_remove_change_ordering.patch (2.0 KB) - added by AlexanderDreyer 7 years ago.
Removing unused (and dangerous) _change_ordering from BooleanPolynomialRing

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by AlexanderDreyer

Removing unused (and dangerous) _change_ordering from BooleanPolynomialRing

comment:1 Changed 7 years ago by AlexanderDreyer

  • Authors set to Alexander Dreyer
  • Description modified (diff)
  • Status changed from new to needs_review

_change_ordering is dead code now and can be removed without problems: pbori_remove_change_ordering.patch

Apply pbori_remove_change_ordering.patch

comment:2 Changed 7 years ago by malb

  • Reviewers set to Martin Albrecht
  • Status changed from needs_review to positive_review

Does what it promises, if doctests pass, this patch is good.

comment:3 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.6.beta3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.