Changes between Initial Version and Version 29 of Ticket #13891


Ignore:
Timestamp:
01/27/13 12:18:47 (6 years ago)
Author:
ppurka
Comment:

This started out as a small patch, but it became quite big already! Anyway, my original fears are all gone. Things seem to work just fine :) I have just a bunch of minor comments now (waiting for the documentation to build):

  1. There is a doctest error
    File "/home/punarbasu/Installations/sage-5.7.beta0/devel/sage-main/sage/graphs/generic_graph.py", line 13803:
        sage: list(sorted(layout_options.iteritems()))
    Expected:
        [('by_component', 'Whether to do the spring layout by connected component -- a boolean.'),
         ('dim', 'The dimension of the layout -- 2 or 3.'),
         ('heights', 'A dictionary mapping heights to the list of vertices at this height.'),
         ('iterations', 'The number of times to execute the spring layout algorithm.'),
         ('layout', 'A layout algorithm -- one of "acyclic", "circular", "ranked", "graphviz", "planar", "spring", or "tree".'),
         ('prog', 'Which graphviz layout program to use -- one of "circo", "dot", "fdp", "neato", or "twopi".'),
         ('save_pos', 'Whether or not to save the computed position for the graph.'),
         ('spring', 'Use spring layout to finalize the current layout.'),
         ('tree_orientation', 'The direction of tree branches -- "up" or "down".'),
         ('tree_root', 'A vertex designation for drawing trees.')]
    Got:
        [('by_component', 'Whether to do the spring layout by connected component -- a boolean.'), ('dim', 'The dimension of the layout -- 2 or 3.'), ('heights', 'A dictionary mapping heights to the list of vertices at this height.'), ('iterations', 'The number of times to execute the spring layout algorithm.'), ('layout', 'A layout algorithm -- one of : "acyclic", "circular" (plots the graph with vertices evenly distributed on a circle), "ranked", "graphviz", "planar", "spring"
    (traditional spring layout, using the graph\'s current positions as initial positions), or "tree" (the tree will be plotted in levels, depending on minimum distance for the root).'), ('prog', 'Which graphviz layout program to use -- one of
    "circo", "dot", "fdp", "neato", or "twopi".'), ('save_pos', 'Whether or not to save the computed position for the graph.'), ('spring', 'Use spring layout to finalize the current layout.'), ('tree_orientation', 'The direction of tree branches -- "up" or "down".'), ('tree_root', 'A vertex designation for drawing trees. a vertex of the tree to be used as the root for the ``layout="tree"`` option. If
    no root is specified, then one is chosen at random. Ignored unless ``layout=\'tree\'``')]
    
  2. I think the following should mention something like "You may want to give it as an argument to graphplot() instead" (i.e. the GraphPlot should be all lower case)
    865	            deprecation(13891, "This method takes no argument ! You may want " 
    866	                               "to give it to GraphPlot instead.")
    

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13891

    • Property Status changed from new to needs_review
    • Property Cc vdelecroix added
    • Property Reviewers changed from to Punarbasu Purkayastha, Sébastien Labbé
  • Ticket #13891 – Description

    initial v29  
    1111
    1212Nathann
     13
     14----
     15Apply to devel/sage
     161. [attachment:trac_13891.patch]
     172. [attachment:trac_13891-second_pass.patch]
     183. [attachment:trac_13891-third_pass.patch]