Opened 8 years ago
Closed 7 years ago
#13888 closed enhancement (fixed)
Barnette Sphere
Reported by: | chapoton | Owned by: | sage-combinat |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.7 |
Component: | combinatorics | Keywords: | simplicial sphere |
Cc: | Merged in: | sage-5.7.beta2 | |
Authors: | Frédéric Chapoton | Reviewers: | Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #13943 | Stopgaps: |
Description (last modified by )
The Barnette Sphere is a triangulation of the 3-sphere. This patch provides this as a simplicial complex
apply trac-13888-barnette-sphere-fc.patch
Attachments (1)
Change History (13)
comment:1 Changed 8 years ago by
- Keywords sphere added
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
comment:3 Changed 7 years ago by
- Status changed from needs_review to positive_review
Hellooooooooooooo !!
Well, I was just able to check the definition of Barnette sphere as given in the third of your references, and those coordinates are not the ones you use... So I added a new doctest that cheks that your definition is equivalent to this one. This is a simplicial complex isomorphism test, so if you end up implemnting it somewhere you can 1) use this code 2) update the doctest.
As everything else is fine, you can set this ticket to positive_review
if you agree with those changes.
Have fuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuunnn !!
Nathann
comment:5 Changed 7 years ago by
- Status changed from needs_work to needs_review
comment:6 Changed 7 years ago by
- Dependencies set to #13943
Changed 7 years ago by
comment:7 Changed 7 years ago by
- Description modified (diff)
apply trac-13888-barnette-sphere-fc.patch
comment:8 Changed 7 years ago by
- Status changed from needs_review to positive_review
Muuuuuuuuuuuuch better than previously, thanks to is_isomorphic
. And it passes all long (and veeeeery long doctests). Good to go !
Nathann
comment:9 Changed 7 years ago by
- Milestone changed from sage-5.6 to sage-5.7
- Reviewers set to Nathann Cohen
comment:10 Changed 7 years ago by
- Milestone changed from sage-5.7 to sage-pending
comment:11 Changed 7 years ago by
- Milestone changed from sage-pending to sage-5.7
comment:12 Changed 7 years ago by
- Merged in set to sage-5.7.beta2
- Resolution set to fixed
- Status changed from positive_review to closed
Hey Frederic,
Just to let you know, right now we are having a discussion over implementation of examples of simplicial complexes in #13566 that might have an impact on this patch.
Best,
Travis