Opened 8 years ago
Last modified 3 years ago
#13886 needs_work defect
Re-enable gcc optional tags for tests.
Reported by: | robertwb | Owned by: | mvngu |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | doctest framework | Keywords: | |
Cc: | jhpalmieri, jdemeyer | Merged in: | |
Authors: | Robert Bradshaw | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #13540 | Stopgaps: |
Description
See #13533.
Attachments (1)
Change History (14)
comment:1 Changed 8 years ago by
- Cc jhpalmieri added
- Status changed from new to needs_review
Changed 8 years ago by
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
So, Jeroen changed his mind?
Or will he be happy because of #13540? (I.e., because those previously optional doctests will then automagically get run -- without having to pass additional parameters to sage -t ...
-- provided the necessary parts, here GCC, are present and functional?)
P.S.: Just realized #13540 is already in the dependencies; found it by reading #13533 ... :-)
comment:4 follow-up: ↓ 5 Changed 8 years ago by
- Cc jdemeyer added
I got the impression that this was a fine change once #13540 went through, though if anyone has objections they're fine to bring up now.
comment:5 in reply to: ↑ 4 Changed 8 years ago by
Replying to robertwb:
I got the impression that this was a fine change once #13540 went through, though if anyone has objections they're fine to bring up now.
Although then testing Sage will presumably take longer ;-) , I'm ok with it. (One should probably be able to explicitly disable such tests. I personally wouldn't like Sage making "arbitrary" internet connections during build or testing, at least by default, but that's #13884, or #13540.)
comment:6 follow-up: ↓ 7 Changed 8 years ago by
I'm pretty sure there are a lot more doctests in Sage which require GCC.
comment:7 in reply to: ↑ 6 Changed 8 years ago by
Replying to jdemeyer:
I'm pretty sure there are a lot more doctests in Sage which require GCC.
Well, then try testing Sage with some "broken" GCC (e.g. exit 1
in $SAGE_LOCAL/bin/gcc
) to see which ones fail, of course without #13540. One may have to incrementally add # optional - gcc
tags to get all of them (and leave out those that are just caused by previous failures)...
comment:8 Changed 7 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:9 Changed 7 years ago by
- Status changed from needs_review to needs_work
comment:10 Changed 6 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:11 Changed 6 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:12 Changed 6 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:13 Changed 3 years ago by
- Component changed from doctest coverage to doctest framework
Unfortunately, http://trac.sagemath.org/sage_trac/attachment/ticket/13533/13533_gcc_not_optional.patch does a lot more than remove "optional - gcc", so this isn't just a rollback.