Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#13876 closed defect (fixed)

Singular and SAGE_DEBUG fixes

Reported by: vbraun Owned by: tbd
Priority: major Milestone: sage-5.7
Component: packages: standard Keywords:
Cc: Merged in: sage-5.7.beta0
Authors: Volker Braun Reviewers: Simon King
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Use SAGE_DEBUG instead of the new and undocumented environment variable SINGULAR_XALLOC.

Also, building the Sage library with SAGE_DEBUG=yes is broken. This is because distutils then does not define NDEBUG which turns on broken Singular debugging stuff.

Updated spkg is at ​http://boxen.math.washington.edu/home/jdemeyer/spkg/singular-3-1-5.p3.spkg

Attachments (1)

singular-p3.diff​ (2.5 KB) - added by vbraun 7 years ago.
diff for review only

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by vbraun

diff for review only

comment:1 Changed 7 years ago by vbraun

  • Authors set to Volker Braun
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 7 years ago by jdemeyer

In SPKG.txt, SINGULAR_DEBUG should be SAGE_DEBUG.

comment:3 Changed 7 years ago by vbraun

Fixed, spkg at same location.

comment:4 Changed 7 years ago by SimonKing

  • Reviewers set to Simon King
  • Status changed from needs_review to positive_review

Sorry, I forgot to review it.

All tests pass, both with and without SAGE_DEBUG=yes, the spkg's repository is clean, the changes are documented in SPKG.txt. Hence, I can give it a positive review.

comment:5 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.6 to sage-5.7

comment:6 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.7.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 Changed 7 years ago by jdemeyer

  • Description modified (diff)
Note: See TracTickets for help on using tickets.