Opened 10 years ago

Closed 10 years ago

#13860 closed enhancement (fixed)

Maxima 5.26.0 update to make it install with also the new ASDF (ECL 12.x)

Reported by: Dima Pasechnik Owned by: Burcin Erocal
Priority: major Milestone: sage-5.6
Component: symbolics Keywords:
Cc: Jean-Pierre Flori, Leif Leonhardy, Karl-Dieter Crisman Merged in: sage-5.6.beta2
Authors: Dmitrii Pasechnik Reviewers: Leif Leonhardy
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Leif Leonhardy)

ECL has moved to use a new ASDF, which means that as of ECL 12, the maxima 5.26.0 spkg stops working with it, due to a small change in the naming scheme of intermediary files. The update takes care of this, and the patched spkg works with both the current ASDF and the new ASDF.

The updated spkg: http://boxen.math.washington.edu/home/dima/packages/maxima-5.26.0.p1.spkg


The main purpose of this ticket is to allow the new ECL from #13324 (with a couple of valuable fixes) to get merged before the new Maxima spkg (5.29.1, #13364) is ready (which unfortunately is unlikely to happen very soon).

Attachments (1)

p0top1_changes.patch (1.9 KB) - added by Dima Pasechnik 10 years ago.
spkg changes - for review only

Download all attachments as: .zip

Change History (12)

comment:1 Changed 10 years ago by Dima Pasechnik

Cc: Jean-Pierre Flori Leif Leonhardy Karl-Dieter Crisman added
Status: newneeds_review

comment:2 Changed 10 years ago by Leif Leonhardy

Authors: Dima Pasechnik
Reviewers: Leif Leonhardy
Status: needs_reviewneeds_work

I've only read the attached patch (why "41", and what's the first file?), but that still contains the bug w.r.t. check_error() (see #13364).

It would also be better to use cp -p[f] ... (and delete some PDF files if we don't install them anyway; cf. #12759).

comment:3 Changed 10 years ago by Leif Leonhardy

I'd also use elif [[ -f maxima.fasb ]]; then ..., since the non-presence of maxima.system.fasb doesn't really imply "Old ASDF".

comment:4 Changed 10 years ago by Dima Pasechnik

Status: needs_workneeds_review

OK, all fixed, please see the updated spkg - and p0tp1_changes.patch.

Please ignore diff41.* - they are for the previous revision.

comment:5 in reply to:  4 ; Changed 10 years ago by Leif Leonhardy

Authors: Dima PasechnikDmitrii Pasechnik

Replying to dimpase:

OK, all fixed, please see the updated spkg - and p0tp1_changes.patch.

Patch looks ok.


Please ignore diff41.* - they are for the previous revision.

Deleted...

comment:6 Changed 10 years ago by Leif Leonhardy

Description: modified (diff)
Summary: maxima 5.26.0 update to make it work with new ASDFMaxima 5.26.0 update to make it install with also the new ASDF (ECL 12.x)

comment:7 in reply to:  5 ; Changed 10 years ago by Leif Leonhardy

Status: needs_reviewpositive_review

Replying to leif:

Patch looks ok.

The spkg as well (and builds with both ECL 11.1 and 12.12; tests pass).

Merry Chrismas.


Deletion of some PDF files (we do not install) from the upstream tree belongs to spkg-dist (and/or should be mentioned in "Special Update/Build Instructions"), but that's for another ticket, IMHO.

comment:8 in reply to:  7 ; Changed 10 years ago by Jeroen Demeyer

Replying to leif:

Deletion of some PDF files (we do not install) from the upstream tree belongs to spkg-dist (and/or should be mentioned in "Special Update/Build Instructions")

+1

Changed 10 years ago by Dima Pasechnik

Attachment: p0top1_changes.patch added

spkg changes - for review only

comment:9 in reply to:  8 Changed 10 years ago by Dima Pasechnik

Replying to jdemeyer:

Replying to leif:

Deletion of some PDF files (we do not install) from the upstream tree belongs to spkg-dist (and/or should be mentioned in "Special Update/Build Instructions")

+1

added a line in spkg-dist for this. spkg updated.

comment:10 Changed 10 years ago by Jean-Pierre Flori

I would have prefered to have the ticket number at the beginning of the changelog (and removed the reference at the end of the pwd part) and put a capital letter at the beginning of the third point, but that's not the most crucial point here.

It is just that I feel our spkgs lack some coherence (and the dev manual some clear guide on how to craft them). And I'm not even thinking of the ATLAS spkg which uses Python :)

Version 0, edited 10 years ago by Jean-Pierre Flori (next)

comment:11 Changed 10 years ago by Jeroen Demeyer

Merged in: sage-5.6.beta2
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.