Opened 7 years ago

Closed 7 years ago

#13844 closed enhancement (fixed)

Let patch build on Cygwin on Windows 7

Reported by: jpflori Owned by: tbd
Priority: major Milestone: sage-5.7
Component: porting: Cygwin Keywords: spkg patch cygwin
Cc: kcrisman, dimpase Merged in: sage-5.7.beta2
Authors: Jean-Pierre Flori Reviewers: Dmitrii Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jpflori)

The solution is simple:

  • revert #11232,
  • install a manifest file.

Use spkg at http://boxen.math.washington.edu/home/jpflori/patch-2.5.9.p3.spkg

Attachments (1)

patch-2.5.9.p3.diff (6.2 KB) - added by jpflori 7 years ago.
Spkg diff, for review only.

Download all attachments as: .zip

Change History (19)

comment:1 follow-up: Changed 7 years ago by jpflori

Spkg coming soon, builds and installs ok and patch seems functional on my Cygwin install.

comment:2 Changed 7 years ago by kcrisman

I assume this is so we can reduce the prereqs for Cygwin?

comment:3 in reply to: ↑ 1 ; follow-up: Changed 7 years ago by kcrisman

Spkg coming soon, builds and installs ok and patch seems functional on my Cygwin install.

Spkg?

comment:4 in reply to: ↑ 3 ; follow-up: Changed 7 years ago by jpflori

Replying to kcrisman:

Spkg coming soon, builds and installs ok and patch seems functional on my Cygwin install.

Spkg?

Soon?

Seriously, I completely got out of the Cygwin stuff since christmas and just started dropping an eye recently on ATLAS and GCC/ECL.

I indeed have a (surely dirty) spkg on my home computer, but as it is surely dirty, I'll wait this week end to have a last look at it and won't scp it everywhere just now.

comment:5 in reply to: ↑ 4 Changed 7 years ago by kcrisman

Seriously, I completely got out of the Cygwin stuff since christmas and just started dropping an eye recently on ATLAS and GCC/ECL.

Fair enough, I wouldn't have asked (since I have patch installed on my Cygwin) except I saw your reappearance.

I indeed have a (surely dirty) spkg on my home computer, but as it is surely dirty, I'll wait this week end to have a last look at it and won't scp it everywhere just now.

I don't think it's necessary yet in any case, since we can first require it, then drop that requirement.

comment:7 Changed 7 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Description modified (diff)
  • Status changed from new to needs_review

comment:8 Changed 7 years ago by kcrisman

Diff looks good, except I don't know about the manifest. I may get a chance to try this Monday, otherwise it will have to wait a few weeks. So partial positive review.

comment:9 Changed 7 years ago by jpflori

New spkg, wrong year in the previous one...

comment:10 Changed 7 years ago by jdemeyer

Please quote $SAGE_LOCAL:

    cp ../patch.exe.manifest "$SAGE_LOCAL/bin/"

Changed 7 years ago by jpflori

Spkg diff, for review only.

comment:11 Changed 7 years ago by jpflori

Done, spkg and diff updated.

comment:12 Changed 7 years ago by kcrisman

This does successfully install on my Cygwin as well. How can I check that this was the patch actually used (as opposed to the patch on my system)? The diff looks fine.

comment:13 Changed 7 years ago by jpflori

You could just run 'which patch' inside a Sage shell and check it points to the Sage installed one.

comment:14 Changed 7 years ago by kcrisman

Sadly, after a required BLODA upgrade to allow my internet access with this machine, Sage won't build - nothing reliable, just the usual horrible stuff and rebasing just delays the pain. Python package in particular is affected. So I wonder whether we should just do this and assume it works on XP. Sorry.

comment:15 Changed 7 years ago by jpflori

  • Cc dimpase added

Maybe Dima can have a look?

On XP the manifest files are not needed, so the only change is that patch is now actually installed (that's the revert #11232 part).

comment:16 Changed 7 years ago by dimpase

  • Status changed from needs_review to positive_review

OK, it works.

comment:17 Changed 7 years ago by jdemeyer

  • Reviewers set to Dmitrii Pasechnik

comment:18 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.7.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.