#1383 closed defect (fixed)
[with patch] Modular Arithmetic Error
Reported by: | trixb4kidz | Owned by: | trixb4kidz |
---|---|---|---|
Priority: | major | Milestone: | sage-2.8.15 |
Component: | number theory | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
I recently discovered that the following commands cause a segfault:
z = Mod(2, 256) z^8
I have already discovered a solution to this problem, which I will post shortly.
Change History (4)
comment:1 Changed 10 years ago by
comment:2 Changed 10 years ago by
I applied the following patch and doctests pass:
# HG changeset patch # User mabshoff@sage.math.washington.edu # Date 1196711612 28800 # Node ID 612d5a72a9e1a9c4eb90a0c746da5a358882b5a0 # Parent f6137fb146cb310be74c0ddb22faa3ee5eaa71a4 Fix modp arithmetic bug [fix by trixb4kidz], added doctest diff -r f6137fb146cb -r 612d5a72a9e1 sage/rings/integer_mod.pyx --- a/sage/rings/integer_mod.pyx Mon Dec 03 11:26:06 2007 -0800 +++ b/sage/rings/integer_mod.pyx Mon Dec 03 11:53:32 2007 -0800 @@ -1836,6 +1836,12 @@ cdef int_fast32_t mod_pow_int(int_fast32 """ Returns base^exp mod n For use in IntegerMod_int + + EXAMPLES: + sage: z = Mod(2, 256) + sage: z^8 + 0 + AUTHOR: -- Robert Bradshaw """ @@ -1860,7 +1866,7 @@ cdef int_fast32_t mod_pow_int(int_fast32 if prod >= INTEGER_MOD_INT32_LIMIT: prod = prod % n exp = exp >> 1 - if prod > n: + if prod >= n: prod = prod % n return prod
Cheers,
Michael
comment:3 Changed 10 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in 2.8.15.rc1.
comment:4 Changed 10 years ago by
- Summary changed from Modular Arithmetic Error to [with patch] Modular Arithmetic Error
Note: See
TracTickets for help on using
tickets.
I haven't figured out Mercurial yet, so I'll post the fix here. I will officially submit a patch later today.
The bug is in the class
IntegerMod_gmp
insage/rings/integer_mod.pyx
. The functionmod_pow_int
needs to be modified as follows: