Opened 9 years ago

Closed 9 years ago

#13815 closed enhancement (fixed)

Fix type + code cleanup in numerical.optimize

Reported by: aapitzsch Owned by: jason, jkantor
Priority: major Milestone: sage-5.6
Component: numerical Keywords:
Cc: Merged in: sage-5.6.beta2
Authors: André Apitzsch Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by aapitzsch)

It's Broyden-Fletcher-Goldfarb-Shanno not Broyden-Fletcher-Goldfarb-Shannon.

The attached patch also uses a python3 compatible syntax to raise errors.

Attachments (1)

trac_13815.patch (3.7 KB) - added by aapitzsch 9 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by vbraun

Please no unnecessary whitespace changes. This only serves to break other people's patches.

Changed 9 years ago by aapitzsch

comment:2 Changed 9 years ago by aapitzsch

  • Description modified (diff)
  • Status changed from new to needs_review

I removed the whitespace changes. Let's hope we get rid of the trailing whitespaces when moving to git.

comment:3 Changed 9 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

The %-operator is deprecated in py3, so I guess we are not fully compliant. But its better than before ;-)

comment:4 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.6.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.