Opened 8 years ago
Closed 8 years ago
#13813 closed defect (fixed)
Fix bug in chessboard graphs generator
Reported by: | dcoudert | Owned by: | jason, ncohen, rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-5.6 |
Component: | graph theory | Keywords: | |
Cc: | sluther, ncohen | Merged in: | sage-5.6.beta0 |
Authors: | David Coudert | Reviewers: | Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
We should normally have:
- The BishopGraph?([d1,d2],radius=r) is isomorphic to the graph obtained merging the edges of the KnightGraphs?([d1,d2],one=i,two=i) for 1<= i <= r.
- The QueenGraph?([d1,d2],radius=r) is isomorphic to the graph obtained merging the edges of a RookGraph?([d1,d2,radius=r) and a BishopGraph?([d1,d2],radius=r)
With current implementation, the result was sometimes incorrect. This patch solves this issue and adds necessary doctests.
Attachments (1)
Change History (6)
Changed 8 years ago by
comment:1 Changed 8 years ago by
- Cc sluther ncohen added
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Status changed from needs_review to positive_review
comment:3 Changed 8 years ago by
Thanks.
comment:4 Changed 8 years ago by
- Reviewers set to Nathann Cohen
comment:5 Changed 8 years ago by
- Merged in set to sage-5.6.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I was about to say that you should replace
if not B.is_isomorphic(H)
byif B != H
, but...Honestly ...
>_<
Nathann