#13809 closed enhancement (fixed)
A constructor for folded cube graphs
Reported by: | ncohen | Owned by: | jason, ncohen, rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-5.6 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | sage-5.6.beta2 | |
Authors: | Nathann Cohen | Reviewers: | David Coudert |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #13862 | Stopgaps: |
Description (last modified by )
Attachments (1)
Change History (15)
comment:1 Changed 6 years ago by
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Reviewers set to David Coudert
- Status changed from needs_review to needs_work
comment:3 Changed 6 years ago by
Also, thanks to patch #11353, the compact version of the complement function is str(~FrozenBitset(x))
, but it is slightly slower for small values of n.
comment:5 Changed 6 years ago by
- Status changed from needs_review to positive_review
For me the patch is good to go (install, test, doc, etc.).
comment:6 follow-up: ↓ 8 Changed 6 years ago by
Just a reminder of something I already said on #13306: you cannot keep adding stuff forever to the file sage/graphs/graph_generators.py.
At some point, I will have to refuse such patches before that file gets really too big.
comment:7 Changed 6 years ago by
Now that we have the generators directory, we can split the graph_generators.py file into dedicated files. Nathann will make such a patch.
comment:8 in reply to: ↑ 6 Changed 6 years ago by
Replying to jdemeyer:
Just a reminder of something I already said on #13306: you cannot keep adding stuff forever to the file sage/graphs/graph_generators.py.
At some point, I will have to refuse such patches before that file gets really too big.
I still have 1.5 hours left before leaving. I'm on it :-P
Nathann
comment:9 Changed 6 years ago by
See #13862, still working on it. *BIG* patch :-P
Nathann
comment:10 Changed 6 years ago by
- Merged in set to sage-5.6.beta2
- Resolution set to fixed
- Status changed from positive_review to closed
comment:11 Changed 6 years ago by
- Description modified (diff)
comment:12 Changed 6 years ago by
- Dependencies set to #13862
comment:13 Changed 6 years ago by
- Description modified (diff)
Changed 6 years ago by
comment:14 Changed 6 years ago by
Put back a sensible commit message.
Two small remarks on this patch: