Opened 10 years ago
Closed 10 years ago
#13796 closed defect (fixed)
fix small bug in Steenrod algebra multiplication
| Reported by: | jhpalmieri | Owned by: | AlexGhitza |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.6 |
| Component: | algebra | Keywords: | steenrod algebra |
| Cc: | Merged in: | sage-5.6.beta1 | |
| Authors: | John Palmieri | Reviewers: | André Apitzsch |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
GitHub link to the corresponding issue
Description
The attached one-line patch (plus doctests) fixes a small bug in multiplication in the Steenrod algebra. It should be easy to review even if you don't know anything about the Steenrod algebra; the code should have defined "F" to be "GF(p)", but it didn't, so "F" is not defined, so it causes an error.
Attachments (1)
Change History (4)
Changed 10 years ago by
| Attachment: | trac_13796-steenrod.patch added |
|---|
comment:1 Changed 10 years ago by
| Status: | new → needs_review |
|---|
comment:2 Changed 10 years ago by
| Reviewers: | → André Apitzsch |
|---|---|
| Status: | needs_review → positive_review |
comment:3 Changed 10 years ago by
| Merged in: | → sage-5.6.beta1 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
I haven't check whether your doc test is correct. Anyway all tests passed. So I give this a positive review.