Opened 10 years ago

Closed 10 years ago

#13794 closed defect (fixed)

sage -n is broken in 5.5rc0

Reported by: Punarbasu Purkayastha Owned by: jason, mpatel, was
Priority: blocker Milestone: sage-5.5
Component: notebook Keywords:
Cc: Merged in: sage-5.5.rc1
Authors: Jeroen Demeyer, John Palmieri Reviewers: Punarbasu Purkayastha
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by John Palmieri)

See this sage-devel thread. I should have opened the bug report here. This is a clear blocker for 5.5.


Apply trac_13794-scripts.patch to the scripts repo.

Attachments (1)

trac_13794-scripts.patch (922 bytes) - added by John Palmieri 10 years ago.
scripts repo

Download all attachments as: .zip

Change History (10)

comment:1 in reply to:  description Changed 10 years ago by Leif Leonhardy

Replying to ppurka:

See this sage-devel thread. I should have opened the bug report here. This is a clear blocker for 5.5.

... or posted to sage-release in the first place ... ;-)

comment:2 Changed 10 years ago by John Palmieri

See also #11409, in particular the scripts patch.

Last edited 10 years ago by John Palmieri (previous) (diff)

comment:3 in reply to:  2 Changed 10 years ago by Punarbasu Purkayastha

Replying to jhpalmieri:

See also #11409, in particular the scripts patch.

I remember having tried only the scripts patch. It didn't work unfortunately. Only the error message changed.

comment:4 Changed 10 years ago by John Palmieri

Maybe we also need this change to sage-notebook and sage-notebook-insecure:

  • sage-notebook

    diff --git a/sage-notebook b/sage-notebook
    a b print open(os.environ['SAGE_ROOT'] + '/l 
    66
    77print "Please wait while the Sage Notebook server starts..."
    88
     9from sage.all import *
    910from sagenb.notebook.all import notebook
    1011
    1112print "..."

comment:5 Changed 10 years ago by John Palmieri

Authors: Jeroen Demeyer, John Palmieri
Status: newneeds_review

Please try the scripts patch from #11409 again. I'm attaching it here and making this ticket a prerequisite for #11409, since it is hard to predict when a new sagenb spkg might be ready, so it's hard to predict when #11409 might get merged.

comment:6 Changed 10 years ago by Punarbasu Purkayastha

Ok. This patch works by itself with the nb in 5.5rc0. Thanks for the fix.

Can you do the following:

  1. change the name of the patch - it has the wrong ticket number.
  2. change the commit message.

I would give it a positive review otherwise.

Changed 10 years ago by John Palmieri

Attachment: trac_13794-scripts.patch added

scripts repo

comment:7 Changed 10 years ago by John Palmieri

Description: modified (diff)

Here's a revised patch.

comment:8 Changed 10 years ago by Punarbasu Purkayastha

Reviewers: Punarbasu Purkayastha
Status: needs_reviewpositive_review

Thanks.

comment:9 Changed 10 years ago by Jeroen Demeyer

Merged in: sage-5.5.rc1
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.