Opened 6 years ago
Closed 6 years ago
#13784 closed defect (fixed)
Move methods from GenericGraph to Graph
Reported by: | ncohen | Owned by: | jason, ncohen, rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-5.6 |
Component: | graph theory | Keywords: | |
Cc: | Merged in: | sage-5.6.beta0 | |
Authors: | Nathann Cohen | Reviewers: | David Coudert |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
From Sage's reference manual :
"Graph stuff that should not be in this file"
This patch solves the problem :
Apply:
Attachments (2)
Change History (11)
Changed 6 years ago by
comment:1 Changed 6 years ago by
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Reviewers set to David Coudert
- Status changed from needs_review to needs_work
comment:3 Changed 6 years ago by
- Status changed from needs_work to needs_review
Weird O_o
I read the source code again, but the conclusion is the same : the cores method is not meant to be used on DiGraph?... I mean : in this situation, it returns the same result as G.cores() on the underlying graph.
I just added another patch that changes this DiGraph
to a Graph
, and tests pass afterwards. I do this in another patch so that the first one only moves methods around without modifying them. Thanks for noticing this !!!!
Nathann
comment:4 Changed 6 years ago by
- Description modified (diff)
comment:5 Changed 6 years ago by
The patch is OK, and it passes successfully tests on the entire graph directory.
However, when looking at the doc, I saw a very small bug that is not due to this patch:
:meth=`~GenericGraph.is_cut_edge` | Returns True if the input edge is a cut-edge or a bridge.
Could you fix this missing ":" after ":meth" in this patch, or is it better to have a dedicated patch?
comment:6 Changed 6 years ago by
No you are right, I already forgot many times to fix it somewhere ^^;
Give me ten seconds :-P
Nathann
comment:7 Changed 6 years ago by
Here it is !
Nathann
Changed 6 years ago by
comment:9 Changed 6 years ago by
- Merged in set to sage-5.6.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
Some updates are needed.