Opened 7 years ago

Closed 7 years ago

#13775 closed defect (fixed)

Bug in the Graph constructor in the presence of loops AND multiple edges

Reported by: ncohen Owned by: tbd
Priority: major Milestone: sage-5.6
Component: graph theory Keywords:
Cc: rbeezer Merged in: sage-5.6.beta2
Authors: Ivan Andrus, Nathann Cohen Reviewers: Ivan Andrus, Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by ncohen)

Having loops is always a bad idea. Loops should be forbidden. Multiedges too. Labels too.

See https://groups.google.com/forum/?fromgroups=#!topic/sage-devel/17pJkcTFuK0

By the way, it was my mistake I know I wrote these lines :-/

Nathann

APPLY:

Attachments (2)

trac_13775.patch (1.2 KB) - added by ncohen 7 years ago.
trac_13775-doctest.patch (653 bytes) - added by iandrus 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by ncohen

  • Component changed from PLEASE CHANGE to graph theory
  • Status changed from new to needs_review

comment:2 follow-up: Changed 7 years ago by iandrus

There's a print left in that I think must have been for debugging.

comment:3 in reply to: ↑ 2 Changed 7 years ago by ncohen

There's a print left in that I think must have been for debugging.

^^;;;;;;;

Nathann

Changed 7 years ago by ncohen

comment:4 Changed 7 years ago by iandrus

It looks good to me and all doctests pass (except one that fails with the patch). Should it have a doctest though? I have included a patch adding one. Other than that I give it a positive review.

Changed 7 years ago by iandrus

comment:5 Changed 7 years ago by ncohen

  • Authors set to Ivan Andrus, Nathann Cohen
  • Description modified (diff)
  • Reviewers set to Ivan Andrus, Nathann Cohen
  • Status changed from needs_review to positive_review

Good idea ! Then this ticket can go.. Thanks ! :-)

Nathann

comment:6 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.6.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.