Opened 9 years ago

Closed 9 years ago

#13769 closed defect (fixed)

CHomP interface: fix usage of CombinatorialFreeModule

Reported by: jhpalmieri Owned by: tbd
Priority: minor Milestone: sage-5.7
Component: interfaces Keywords:
Cc: Merged in: sage-5.7.beta4
Authors: John Palmieri Reviewers: Christian Nassau
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12587 Stopgaps:

Status badges

Description

At some point, the means of setting options for a CombinatorialFreeModule changed, but the file interfaces/chomp.py didn't get upgraded to use the new versions. As a result, some doctests fail in that file when CHomP is installed and sage -t --optional .... is run on it. The attached patch fixes this.

Attachments (1)

trac_13769-chomp.patch (1.9 KB) - added by jhpalmieri 9 years ago.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by jhpalmieri

comment:1 Changed 9 years ago by jhpalmieri

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by jhpalmieri

  • Dependencies set to #12587

comment:3 follow-up: Changed 9 years ago by cnassau

  • Authors set to John Palmieri
  • Reviewers set to Christian Nassau
  • Status changed from needs_review to positive_review

On OpenSuse? 12.2 with gcc version 4.7.1 20120723 the CHomP package can't be installed: I had to fix some C++ name resolution errors first:

  • change 'erase' to 'this->erase' in 'include/capd/homologicalAlgebra/ChainT.h'
  • change 'containsPixel' to 'this->containsPixel' in 'include/capd/bitSet/CubSetT.hpp'

With these changes CHomP can be installed and the attached patch does indeed fix the mentioned doctest failures.

comment:4 in reply to: ↑ 3 Changed 9 years ago by cnassau

Replying to cnassau:

I've made this #14076

comment:5 Changed 9 years ago by jdemeyer

  • Component changed from optional packages to interfaces

comment:6 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.7.beta4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.