Opened 9 years ago

Last modified 8 years ago

#13767 closed enhancement

upgrade boost to version 1.52.0 — at Version 8

Reported by: tkluck Owned by: tbd
Priority: minor Milestone: sage-5.8
Component: packages: standard Keywords:
Cc: jpflori Merged in:
Authors: Timo Kluck Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

There was a discussion on sage-devel a while ago about including the Boost headers [1]. As noted there, the latest version of the optional spkg polymake doesn't compile with the current boost package. The current boost package is called boost-cropped because it contains only a subset of the boost headers, because of package size.

This new package is contains all headers, which is still only a subset of the upstream tarball. The total packaged size is ~ 5M, which feels reasonable to me.

I've checked that the current version polybori-0.8.2 and the current upstream version polymake-2.12-rc3 both compile under Sage with these headers. I'm also submitting an spkg for polymake in another ticket.


Change History (8)

comment:1 Changed 9 years ago by tkluck

Because of the file size limit on trac attachment, I've put it here:

comment:2 Changed 9 years ago by tkluck

  • Status changed from new to needs_review

comment:3 Changed 8 years ago by vbraun

The deleted patch is still in the repo:

[vbraun@laptop boost-cropped-1.52.0]$ hg st
! patches/boost-1.34.1-gcc-4.4.0-fixes.patch

Also, I take it the following in SPKG.txt is no longer true?

Merged against policy a patch that makes boost build with gcc 4.4.0. Will be obsoleted by an updated boost shortly.

comment:4 Changed 8 years ago by tkluck

Thanks for reviewing. I've removed that line from SKPG.txt, and committed my changes into the hg repo. I also renamed the package to boost_cropped (underscore instead of dash) to conform to the name-version scheme.

The current version is here:

comment:5 Changed 8 years ago by tkluck

I just uploaded a slightly newer version (md5sum d897d8e152623fab9f9c866ce184b501) that fixes a bash escaping error in spkg-install that I happened to notice.

comment:6 Changed 8 years ago by vbraun

+1 for underscore but don't we have to patch those as well?

[vbraun@laptop Sage]$ egrep boost-cropp sage/spkg/*
sage/spkg/install:BOOST_CROPPED=`newest_version boost-cropped`

comment:7 Changed 8 years ago by tkluck

I attached a patch doing just that. I don't know how to instruct the patchbot to apply this to sage_root, and it wouldn't work anyway since it needs the new spkg. Let me know if I can do anything more, though.

Note that the file spkg/Makefile is automatically generated, so I didn't patch it.

Last edited 8 years ago by tkluck (previous) (diff)

comment:8 Changed 8 years ago by vbraun

  • Description modified (diff)
  • Reviewers set to Volker Braun
Note: See TracTickets for help on using tickets.