Changes between Initial Version and Version 1 of Ticket #13765, comment 9
 Timestamp:
 01/25/13 12:29:44 (7 years ago)
Legend:
 Unmodified
 Added
 Removed
 Modified

Ticket #13765, comment 9
initial v1 1 * I tested the patch using Sage 5.5.2 * It is well documented and it solves the bug as far as I can see.3 * The documentation builds.1 * I tested the patch using Sage 5.5. 2 * It is well documented and it solves the bug as far as I can see. 3 * The documentation builds. 4 4 5 But I am not convinced that the implementation of NumberField_cyclotomic._log_gen should stay like it is. It is a private method but it might be used within the class for ther purposes later. 6 Therefore, I think the output should always make sense. But it doesn't always and it is not completely consistent. Here is an Example. 5 But I am not convinced that the implementation of !NumberField_cyclotomic._log_gen should stay like it is. It is a private method but it might be used within the class for ther purposes later. Therefore, I think the output should always make sense. But it doesn't always and it is not completely consistent. Here is an Example. 7 6 8 7 This is what I expect from the documentation: … … 14 13 <type 'NoneType'> 15 14 }}} 15 So, this is o.k., but: 16 16 17 So, this is o.k., but:18 17 {{{ 19 18 sage: K.<zeta>=CyclotomicField(5, embedding=CC(exp(2*pi*i/5))) … … 23 22 sage: <type 'sage.rings.integer.Integer'> 24 23 }}} 25 26 24 This behaviour is more or less documented in the docstring. It says that "If x is complex, returns the nearest such e whether or not the result is exact.". But I don't agree that it should be this way. 27 25